Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Fix old project system warnings #710

Merged
merged 2 commits into from
Apr 18, 2018
Merged

Fix old project system warnings #710

merged 2 commits into from
Apr 18, 2018

Commits on Apr 17, 2018

  1. Fix warnings in old project system (.NETFramework projects) 

    When NETStandard.Library was referenced in a .NETFramework project using the old project system,
it would evaluate the project ignoring conditions on ItemGroups.  Apparently this is done to
display the superset of project configurations (eg both debug and release) in the solution heirarchy.
The warnings were a result of the items never being resolved after design time build finished
resolving references (because of course the items were conditioned out for the target framework).

We can workaround this using choose/when.  Apparently the evaluation of the project is bold
enough to ignore the conditions on an itemgroup, but not bold enough to choose one of many
when (or all) clauses. :)
    @ericstj
    ericstj committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    94c3772 View commit details
    Browse the repository at this point in the history

  2. Fix extraneous slash in reference paths 

    We were appending an unnecessary slash after MSBuildThisFileDirectory in our targets.

This wasn't breaking anything but it should be cleaned up to avoid being a red-herring.
    @ericstj
    ericstj committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    ccb4db7 View commit details
    Browse the repository at this point in the history