Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/arcade #239

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 18, 2021

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 5b58eaee-79a7-4540-8274-08d8e9754760
  • Build: 20210317.3
  • Date Produced: 3/17/2021 7:18 PM
  • Commit: 0ca849f0b71866b007fedaaa938cee63f8d056a6
  • Branch: refs/heads/main

…317.3

Microsoft.DotNet.Arcade.Sdk
 From Version 6.0.0-beta.21105.12 -> To Version 6.0.0-beta.21167.3
@MichaelSimons
Copy link
Member

This version of Arcade is upgrading the .NET toolset to 6.0. There appears to be some test projects that target .net5 which break.

Test Failure

It was not possible to find any compatible framework version
The framework 'Microsoft.NETCore.App', version '5.0.0' was not found.
  - The following frameworks were found:
      6.0.0-preview.2.21154.6 at [/datadisks/disk1/workspace/_work/1/s/.dotnet/shared/Microsoft.NETCore.App]

You can resolve the problem by installing the specified framework and/or SDK.

The specified framework can be found at:
  - https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=5.0.0&arch=x64&rid=ubuntu.16.04-x64
=== COMMAND LINE ===
"/datadisks/disk1/workspace/_work/1/s/.dotnet/dotnet" exec --depsfile "/datadisks/disk1/workspace/_work/1/s/artifacts/bin/Microsoft.DiaSymReader.Native.UnitTests/Debug/net5/Microsoft.DiaSymReader.Native.UnitTests.deps.json" --runtimeconfig "/datadisks/disk1/workspace/_work/1/s/artifacts/bin/Microsoft.DiaSymReader.Native.UnitTests/Debug/net5/Microsoft.DiaSymReader.Native.UnitTests.runtimeconfig.json"  "/datadisks/disk1/workspace/_work/1/s/.packages/xunit.runner.console/2.4.1/tools/netcoreapp2.0/xunit.console.dll" "/datadisks/disk1/workspace/_work/1/s/artifacts/bin/Microsoft.DiaSymReader.Native.UnitTests/Debug/net5/Microsoft.DiaSymReader.Native.UnitTests.dll" -noautoreporters -xml "/datadisks/disk1/workspace/_work/1/s/artifacts/TestResults/Debug/Microsoft.DiaSymReader.Native.UnitTests_net5_x64.xml" -html "/datadisks/disk1/workspace/_work/1/s/artifacts/TestResults/Debug/Microsoft.DiaSymReader.Native.UnitTests_net5_x64.html"  > "/datadisks/disk1/workspace/_work/1/s/artifacts/log/Debug/Microsoft.DiaSymReader.Native.UnitTests_net5_x64.log" 2>&1

@tmat - can you please take a look? A new arcade is needed to resolve #236 and unblock source-build.

cc @mmitche

Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW - LGTM

@MichaelSimons
Copy link
Member

@tmat - Friendly ask on who needs to review so that this can get merged?

@tmat tmat merged commit fffb679 into main Mar 23, 2021
@tmat tmat deleted the darc-main-bb0250fb-da08-4b5e-a47e-048b2ccaa291 branch March 23, 2021 23:45
@MichaelSimons
Copy link
Member

Thanks @tmat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants