Add HttpResponse APIs (ClearHeaders/WriteFile/TransmitFile/etc) #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twsouthwick
force-pushed
the
tasou/httpresponse-writefile
branch
3 times, most recently
from
f47cc91
to
98b90ce
Compare
These APIs are essentially the same, except that they had different memory characteristics. TransmitFile did not buffer, while WriteFile did. On ASP.NET Core, these will just delegate to IHttpResponseBodyFeature.SendFileAsync. NOTE: This implementation will call Task.GetAwaiter().GetResult(). We could potentially expose an async API for this on the ASP.NET Core side as a stepping stone if we want. Part of #91
twsouthwick
force-pushed
the
tasou/httpresponse-writefile
branch
from
98b90ce
to
5d105c3
Compare
twsouthwick
changed the title
38 tasks
twsouthwick
force-pushed
the
tasou/httpresponse-writefile
branch
from
d9b2e8b
to
6b9baf0
Compare
mjrousos
requested changes
Jul 12, 2022
Tratcher
reviewed
Jul 12, 2022
Tratcher
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a few APIs that were missing from HttpResponse.
SubStatusCode is a placeholder for the value, but does not actually publish it anywhere.
TransmitFile/WriteFile: These APIs are essentially the same, except that they had different memory characteristics. TransmitFile did not buffer, while WriteFile did. On ASP.NET Core, these will just delegate to IHttpResponseBodyFeature.SendFileAsync.
NOTE: This implementation will call Task.GetAwaiter() which should be avoided. We could potentially expose an async API for this on the ASP.NET Core side as a stepping stone if we want.
Part of #91