async output #344
Merged
async output #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 24, 2019 12:28
jonsequitur
reviewed
Jul 24, 2019
Microsoft.DotNet.Interactive.Jupyter.Tests/ExecuteRequestHandlerTests.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
Jul 24, 2019
jonsequitur
reviewed
Jul 24, 2019
jonsequitur
reviewed
Jul 24, 2019
|
|
||
| var kernelCommand = new SubmitCode(@" | ||
| Console.Write(DateTime.Now); | ||
| System.Threading.Thread.Sleep(1000); |
There was a problem hiding this comment.
Using a custom scheduler, we wouldn't need an actual Thread.Sleep and the test can run faster.
colombod
approved these changes
Jul 24, 2019
jonsequitur
reviewed
Jul 24, 2019
| @@ -210,6 +191,22 @@ private void SetupScriptOptions() | |||
| } | |||
| } | |||
|
|
|||
| private void PublishOutput(string std, KernelInvocationContext context, IKernelCommand command) | |||
jonsequitur
reviewed
Jul 24, 2019
jonsequitur
reviewed
Jul 24, 2019
| { | ||
| Subject<string> WriteEvents = new Subject<string>(); |
There was a problem hiding this comment.
Please specify private.
jonsequitur
reviewed
Jul 24, 2019
| @@ -20,6 +27,39 @@ private class Region | |||
| readonly List<Region> _regions = new List<Region>(); | |||
added 2 commits
July 24, 2019 15:46
jonsequitur
reviewed
Jul 24, 2019
| { | ||
| var formattedValues = new List<FormattedValue> | ||
| { | ||
| new FormattedValue( | ||
| Formatter.MimeTypeFor(std?.GetType() ?? typeof(object)), std) | ||
| Formatter.MimeTypeFor(output?.GetType() ?? typeof(object)), output) |
There was a problem hiding this comment.
Or Formatter.MimeTypeFor(typeof(string))?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.