Support json as config as well as yaml #355
Conversation
| string yamlContent = serializer.Serialize(obj); | ||
|
|
||
| using var parser = new YamlParser(yamlContent); | ||
| return parser.ParseConfigApplication(); |
There was a problem hiding this comment.
Is this step even needed? (would YamlParser just parse the JSON document since JSON is YAML).
I'm thinking about things like line-numbers matching up if we do a conversion step. We just did a bunch of work in the yaml parser/validator to get better error messages with line numbers.
There was a problem hiding this comment.
Good question, would have to test. First though is no. Yaml is format (space) specific where JSON can be one line no spaces and still be valid.
| @@ -2,6 +2,7 @@ | |||
| // The .NET Foundation licenses this file to you under the MIT license. | |||
| // See the LICENSE file in the project root for more information. | |||
|
|
|||
| using k8s; | |||
There was a problem hiding this comment.
Does this class actually use the k8s OM for anything?
src/tye/InitHost.cs
Outdated
| { | ||
| if (path is FileInfo && path.Exists && !force) | ||
| { | ||
| ThrowIfTyeFilePresent(path, "tye.yml"); | ||
| ThrowIfTyeFilePresent(path, "tye.yaml"); | ||
|
|
||
| if (json) | ||
| ThrowIfTyeFilePresent(path, "tye.json"); |
There was a problem hiding this comment.
This check should probably happen regardless of json being true/false. We don't want to create a tye.yaml if you already have tye.json without force.
| @@ -77,7 +88,7 @@ public static (string, string) CreateTyeFileContent(FileInfo? path, bool force) | |||
| } | |||
|
|
|||
| // If the input file is a sln/project then place the config next to it | |||
| outputFilePath = Path.Combine(directory.FullName, "tye.yaml"); | |||
| outputFilePath = Path.Combine(directory.FullName, outputFilePath); | |||
There was a problem hiding this comment.
What does this do with our comments? https://github.com/dotnet/tye/pull/355/files#diff-03e018baedc83b3a7dd33c431001ccfdR48 when you do JSON?
There was a problem hiding this comment.
Comments are not supported in JSON. Also consider the following note from http://www.yaml.org/spec/1.2/spec.html section 3.2.3.3. Comments
Comments are a presentation detail and must not have any effect on the serialization tree or representation graph...
|
|
||
| var json = serializer.Serialize(yamlObject); | ||
|
|
||
| return json; |
There was a problem hiding this comment.
It would be really nice if this could also inject $schema pointing at: https://raw.githubusercontent.com/dotnet/tye/master/src/schema/tye-schema.json
|
This was a good spike. Moving away in favor of current configuration option, |
Addresses #15