Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

Support JSON in addition to YAML #15

Closed
rynowak opened this issue Mar 1, 2020 · 7 comments
Closed

Support JSON in addition to YAML #15

rynowak opened this issue Mar 1, 2020 · 7 comments
Labels
Milestone

Comments

@rynowak
Copy link
Member

rynowak commented Mar 1, 2020

Some people have hate in their hearts for YAML. It's really cheap for us to support JSON as well as YAML, since YAML can be converted to YAML. https://github.com/aaubry/YamlDotNet/wiki/Samples.ConvertYamlToJson

Additionally, JSON has better support for schema/intellisense

We could do this by making JSON the source of truth and then converting YAML to JSON (always)

@rynowak rynowak added the idea label Mar 1, 2020
@rynowak rynowak added this to the backlog milestone Mar 3, 2020
@PureKrome
Copy link
Contributor

since YAML can be converted to YAML.

I think you ment "since YAML can be converted to JSON".

And yes, would love json as the source of truth. But it's now 6 weeks after this issue, so i'm guessing this boat has sailed ... ⛵

@jkotalik
Copy link
Contributor

No boats have sailed here! This project is just starting, and the last 6 weeks we honestly have been mostly working on documentation and paper cuts that people are running into, no major feature work besides core fundamentals (ex service discovery).

@PureKrome
Copy link
Contributor

woot! and cheers @spboyer for the PR. Respect, mate 👍

Respect to the entire team, actually 👍

@spboyer
Copy link
Contributor

spboyer commented May 14, 2020

@rynowak @jkotalik - can we close? Did a spike on this with #355 and we didn't merge as YAML was the better choice moving forward.

@rynowak
Copy link
Member Author

rynowak commented May 14, 2020

I think @davidfowl will be really happy to see this closed.

@rynowak rynowak closed this as completed May 14, 2020
@davidfowl
Copy link
Member

😄

@PureKrome
Copy link
Contributor

Ok - so summary/answer is: YAML config only. No JSON config support.

yes?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants