Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some tests that would fail when running under a non en-US culture #5268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix some tests that would fail when running under a non en-US culture #5268

wants to merge 1 commit into from

Commits on Dec 14, 2023

  1. Fix some tests that would fail when running under a non en-US culture 

    Before this commit, two tests would fail with this error (FaultExceptionTest.Serializable_TDetail and FaultExceptionTest.Serializable_Default):
```
Xunit.Sdk.EqualException
Assert.Equal() Failure
                                 ↓ (pos 1259)
Expected: ···:text><a:xmlLang>en-US</a:xmlLang></a:FaultException.FaultRea···
Actual:   ···:text><a:xmlLang>fr-CH</a:xmlLang></a:FaultException.FaultRea···
                                 ↑ (pos 1259)
```

Explicitly setting the expected culture with a `BeforeAfterTestAttribute` solves this issue.
    @0xced
    0xced committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    15f647b View commit details
    Browse the repository at this point in the history