Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test: AxHost_GetIFontFromFont_InvokeSimpleStyle_Roundtrips #2003

Closed
RussKie opened this issue Oct 2, 2019 · 1 comment · Fixed by #2736
Closed

Flaky test: AxHost_GetIFontFromFont_InvokeSimpleStyle_Roundtrips #2003

RussKie opened this issue Oct 2, 2019 · 1 comment · Fixed by #2736
Labels
test-bug Problem in test source code (most likely)

Comments

@RussKie
Copy link
Member

RussKie commented Oct 2, 2019

  • .NET Core Version: master @ 3750c43

Problem description:

AxHost_GetIFontDispFromFont_InvokeSimpleStyle_Roundtrips test fails locally from cli and VS:

  Message: 
    Assert.Equal() Failure
    Expected: 0
    Actual:   254
  Stack Trace: 
    AxHostTests.AxHost_GetIFontFromFont_InvokeSimpleStyle_Roundtrips() line 1083

Expected behavior:

The test pass

/cc: @hughbe

@RussKie RussKie added the test-bug Problem in test source code (most likely) label Oct 2, 2019
@weltkante
Copy link
Contributor

weltkante commented Oct 2, 2019

One thing I notice is that the port of IFont is missing two interface methods (added annotations [1] [2] in the original commit) - but I don't think those can be responsible here because they come after the method reading the charset property. Created #2007 since its a separate issue.

Something else: is AxHost_GetIFontDispFromFont_InvokeSimpleStyle_Roundtrips done on STA, being only annotated with a [Fact] attribute? I don't know if OLE ActiveX functions are working correctly outside STA ... considering that the OleInitialize native API initializes the thread to STA I'd expect all OLE functions to require STA ... in this case it might be solved together with #1999 by using the proper test annotations

RussKie added a commit to RussKie/winforms that referenced this issue Oct 2, 2019
@merriemcgaw merriemcgaw added this to the Future milestone Oct 3, 2019
@ghost ghost added the 🚧 work in progress Work that is current in progress label Jan 19, 2020
@ghost ghost removed the 🚧 work in progress Work that is current in progress label Jan 19, 2020
@RussKie RussKie removed this from the Future milestone Jan 19, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test-bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants