Fix IFont and IPicture definitions #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughbe
force-pushed
the
Fix-IPicture-Definitions
branch
2 times, most recently
from
b8b9e6f
to
e3806cb
Compare
Codecov Report
@@ Coverage Diff @@
## master #2736 +/- ##
==================================================
+ Coverage 58.12112% 58.1742% +0.05308%
==================================================
Files 1240 1240
Lines 423008 423014 +6
Branches 38852 38852
==================================================
+ Hits 245857 246085 +228
+ Misses 171777 171565 -212
+ Partials 5374 5364 -10
|
weltkante
reviewed
Jan 18, 2020
...tests/UnitTests/System/Windows/Forms/ComponentModel/Com2Interop/COM2PictureConverterTests.cs
Outdated
Show resolved
Hide resolved
hughbe
force-pushed
the
Fix-IPicture-Definitions
branch
from
e3806cb
to
f8ca7f5
Compare
RussKie
approved these changes
Jan 19, 2020
|
Thank you! |
|
#2004 (comment) goes into what is happening here. These problems are another reason I'm keen on utilizing structs for native typedefs (#2069). |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
IFontmethodsIFontandIPicturetestsWinFormsFactto run on STA threadHDC/HPALETTE/HBITMAP/HENHMETAFILE/HMETAFILE/HFONTints notuints due to sign extension bugs/cc @weltkante @JeremyKuhne
Fixes #2002, Fixes #2003, Fixes #2004, Fixes #2005, Fixes #2007
Microsoft Reviewers: Open in CodeFlow