Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete obsolete ResourceConsumption/ResourceExposure attributes #321

Closed
kevingosse opened this issue Jan 15, 2019 · 2 comments
Closed

Delete obsolete ResourceConsumption/ResourceExposure attributes #321

kevingosse opened this issue Jan 15, 2019 · 2 comments
Labels
enhancement Product code improvement that does NOT require public API changes/additions good first issue Issue should be easy to implement, good for first-time contributors help wanted Good issue for external contributors
Milestone
3.0-Preview3

Comments

@kevingosse
Copy link
Contributor

Those attributes are present in a few places in the code and can be probably removed (see dotnet/corefx#30863).
@kevingosse kevingosse mentioned this issue Jan 15, 2019
Merged
@zsd4yr zsd4yr added enhancement Product code improvement that does NOT require public API changes/additions help wanted Good issue for external contributors good first issue Issue should be easy to implement, good for first-time contributors labels Jan 16, 2019
@zacpwhite zacpwhite mentioned this issue Feb 8, 2019
Merged
@zacpwhite
Copy link
Contributor

I just submitted PR #419 which should meet these requirements.

@RussKie RussKie mentioned this issue Feb 13, 2019
Closed
@merriemcgaw merriemcgaw added this to the Future milestone Feb 22, 2019
@merriemcgaw
Copy link
Member

PR #419 is merged, closing this issue.

@zsd4yr zsd4yr modified the milestones: Future, 3.0 - Preview 3 Apr 23, 2019
@dotnet dotnet locked as resolved and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Product code improvement that does NOT require public API changes/additions good first issue Issue should be easy to implement, good for first-time contributors help wanted Good issue for external contributors
Projects
None yet
Milestone
3.0-Preview3
Development

No branches or pull requests
4 participants
@zacpwhite @zsd4yr @kevingosse @merriemcgaw