Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ControlPaint.DrawSizeGrip leaves a gap in rendering #3953

Closed
JeremyKuhne opened this issue Sep 18, 2020 · 2 comments · Fixed by #3955 or #3956
Closed

ControlPaint.DrawSizeGrip leaves a gap in rendering #3953

JeremyKuhne opened this issue Sep 18, 2020 · 2 comments · Fixed by #3955 or #3956
Assignees
@JeremyKuhne
Labels
💥 regression-preview Regression from a preview release

Comments

@JeremyKuhne
Copy link
Member

DrawSizeGrip is one pixel too short on the right.

            bounds = new Rectangle(500, 300, 20, 20);
            ControlPaint.DrawSizeGrip(e.Graphics, Color.Blue, bounds);
            e.Graphics.DrawRectangle(Pens.Red, bounds);

Good is on the left, bad is on the right:

image
@JeremyKuhne JeremyKuhne added this to the 5.0 RC2 milestone Sep 18, 2020
@JeremyKuhne JeremyKuhne self-assigned this Sep 18, 2020
JeremyKuhne added a commit to JeremyKuhne/winforms that referenced this issue Sep 19, 2020
@JeremyKuhne
Fix DrawSizeGrip
9544d59 
End point needed adjusted for GDI to match GDI+

Fixes dotnet#3953
@JeremyKuhne
Copy link
Member Author

This also leaves a new gap on Forms that aren't drawn using visual styles.

@JeremyKuhne JeremyKuhne mentioned this issue Sep 19, 2020
Merged
JeremyKuhne added a commit that referenced this issue Sep 19, 2020
@JeremyKuhne
Fix DrawSizeGrip (#3955)
475f90a 
End point needed adjusted for GDI to match GDI+

Fixes #3953
JeremyKuhne added a commit to JeremyKuhne/winforms that referenced this issue Sep 19, 2020
@JeremyKuhne
Fix DrawSizeGrip (dotnet#3955)
bfeb6e0 
End point needed adjusted for GDI to match GDI+

Fixes dotnet#3953
@JeremyKuhne JeremyKuhne mentioned this issue Sep 19, 2020
Merged
@ghost ghost added the 🚧 work in progress Work that is current in progress label Sep 19, 2020
@RussKie RussKie added 💥 regression-preview Regression from a preview release Priority:1 Work that is critical for the release, but we could probably ship without labels Sep 21, 2020
@RussKie RussKie linked a pull request Sep 21, 2020 that will close this issue
Fix ControlPaint regressions #3956
Merged
@RussKie RussKie reopened this Sep 21, 2020
JeremyKuhne added a commit to JeremyKuhne/winforms that referenced this issue Sep 21, 2020
@JeremyKuhne
Proposing porting the changes that fix the class of off by one bugs f…
82c767a 
…or the end point of lines that were switched from GDI+ to GDI (for performance and memory usage). Note that the majority of the code in these commits are test code.

Fixes dotnet#3953
Fixes dotnet#3945
Fixes dotnet#3931
Fixes dotnet#3944
@JeremyKuhne JeremyKuhne mentioned this issue Sep 21, 2020
Closed
@ghost ghost removed the 🚧 work in progress Work that is current in progress label Sep 23, 2020
@RussKie RussKie removed this from the 5.0 RC2 milestone Sep 24, 2020
@RussKie RussKie removed the Priority:1 Work that is critical for the release, but we could probably ship without label Sep 24, 2020
@RussKie RussKie closed this as completed Sep 24, 2020
@John-Qiao
Copy link
Member

Verified the issue in Dev16 16.9.0 Preview 1.0 [30527.11.main] + .NET 5.0.100-rc.2.20477.2 from RC2 branch , this issue has been fixed as below:
TestResult

@ghost ghost locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JeremyKuhne JeremyKuhne

Labels
💥 regression-preview Regression from a preview release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix DrawSizeGrip JeremyKuhne/winforms
Fix ControlPaint regressions JeremyKuhne/winforms
3 participants
@RussKie @JeremyKuhne @John-Qiao