Port one-off line drawing fixes to RC2 #3961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or the end point of lines that were switched from GDI+ to GDI (for performance and memory usage). Note that the majority of the code in these commits are test code. Fixes dotnet#3953 Fixes dotnet#3945 Fixes dotnet#3931 Fixes dotnet#3944
JeremyKuhne
added
the
Servicing-consider
ghost
assigned 
RussKie
approved these changes
Sep 21, 2020
Codecov Report
@@ Coverage Diff @@
## release/5.0-rc2 #3961 +/- ##
==========================================================
+ Coverage 67.64830% 98.10163% +30.45332%
==========================================================
Files 1410 491 -919
Lines 507284 256536 -250748
Branches 41180 4322 -36858
==========================================================
- Hits 343169 251666 -91503
+ Misses 158124 4134 -153990
+ Partials 5991 736 -5255
Flags with carried forward coverage won't be shown. Click here to find out more. |
merriemcgaw
removed
the
Servicing-consider
|
Taking #3956 instead |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing porting the changes that fix the class of off by one bugs for the end point of lines that were switched from GDI+ to GDI (for performance and memory usage). Note that the majority of the code in these commits are test code.
Fixes #3953
Fixes #3945
Fixes #3931
Fixes #3944
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
UpDownControl example, before and after:
Good grab handle is on left, bad is on right: (while the right may look more appealing out of context making it "centered" would require all users to upgrade their code to get their existing behavior)
Good DrawBorder is on the left, bad on the right. The dotted/dashed are ok as that always draws with GDI+.
Bad DrawBorder on left, good on right.
Test methodology
Microsoft Reviewers: Open in CodeFlow