Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for TextBox #11021

Merged
merged 9 commits into from
Apr 19, 2024
Merged

Conversation

Eudora-Li01
Copy link
Contributor

@Eudora-Li01 Eudora-Li01 commented Mar 11, 2024

Related ##10453

Proposed changes

  • Add unit tests for TextBox to test its properties: AutoCompleteMode and AutoCompleteSource.
  • Add renderer unit tests for TextBox to test its methods: DrawTestBox

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.36411%. Comparing base (cef4d2a) to head (8e10713).
Report is 11 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11021         +/-   ##
===================================================
+ Coverage   73.47398%   74.36411%   +0.89012%     
===================================================
  Files           3101        3010         -91     
  Lines         632447      625073       -7374     
  Branches       46688       46502        -186     
===================================================
+ Hits          464684      464830        +146     
+ Misses        164355      156835       -7520     
  Partials        3408        3408                 
Flag Coverage Δ
Debug 74.36411% <100.00000%> (+0.89012%) ⬆️
integration 18.36385% <ø> (ø)
production 46.98086% <ø> (+0.01729%) ⬆️
test 97.06625% <100.00000%> (+2.07797%) ⬆️
unit 43.95043% <ø> (+0.01764%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Eudora-Li01 Eudora-Li01 added the waiting-review This item is waiting on review by one or more members of team label Mar 13, 2024
@Tanya-Solyanik Tanya-Solyanik added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Mar 14, 2024
@LeafShi1
Copy link
Member

@lonitra Please help review this PR

@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Mar 18, 2024
@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Mar 18, 2024
@Eudora-Li01 Eudora-Li01 marked this pull request as draft March 21, 2024 07:51
@dotnet-policy-service dotnet-policy-service bot added the draft draft PR label Mar 21, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Apr 15, 2024
@Eudora-Li01 Eudora-Li01 marked this pull request as ready for review April 17, 2024 06:04
@dotnet-policy-service dotnet-policy-service bot removed the draft draft PR label Apr 17, 2024
@Eudora-Li01 Eudora-Li01 added the waiting-review This item is waiting on review by one or more members of team label Apr 18, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lonitra lonitra added ready-to-merge PRs that are ready to merge but worth notifying the internal team. and removed waiting-review This item is waiting on review by one or more members of team labels Apr 18, 2024
@lonitra lonitra merged commit 3a1180c into dotnet:main Apr 19, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview4 milestone Apr 19, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Apr 19, 2024
@Eudora-Li01 Eudora-Li01 deleted the Add_Coverage_For_TextBox branch April 22, 2024 01:16
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants