Mark ComNativeDescriptor-related code as RequiresUnreferencedCode #11165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11165 +/- ##
===================================================
+ Coverage 73.39570% 73.44632% +0.05061%
===================================================
Files 3097 3098 +1
Lines 632131 632225 +94
Branches 46652 46653 +1
===================================================
+ Hits 463957 464346 +389
+ Misses 164791 164478 -313
- Partials 3383 3401 +18
Flags with carried forward coverage won't be shown. Click here to find out more. |
LakshanF
approved these changes
Apr 5, 2024
sbomer
added a commit
to dotnet/runtime
that referenced
this pull request
Apr 8, 2024
Together with dotnet/winforms#11165, this removes some COM-related trim warnings in a winforms test app by disabling support for browsing COM objects via the TypeDescriptor APIs.
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
Together with dotnet/winforms#11165, this removes some COM-related trim warnings in a winforms test app by disabling support for browsing COM objects via the TypeDescriptor APIs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some warnings in a winforms app by propagating RUC to code related to ComNativeDescriptor.
The app still produces one related warning for dotnet/runtime's reference (by name) to ComNativeDescriptor, which I plan to address with a feature switch. The code path is not needed in the trimmed test app.
Microsoft Reviewers: Open in CodeFlow