Code cleanup only and Add VB Tests #11215
Conversation
…e New() with Modules
Remove VB Options from Source
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11215 +/- ##
===================================================
+ Coverage 74.43217% 74.59650% +0.16433%
===================================================
Files 3039 3054 +15
Lines 629056 630539 +1483
Branches 46834 46865 +31
===================================================
+ Hits 468220 470360 +2140
+ Misses 157483 156830 -653
+ Partials 3353 3349 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@KlausLoeffelmann can you get someone assigned to review please. This consolidates much of the cleanup and adds testing to VB code. Some files are not touched as they require code changes covered in other PR's. |
Fix up code issues
|
You are much more likely to get a PR merged if its smaller. Large change sets like this are very hard to review properly unless its a singular change like applying a code fix. Do not add more stuff to this PR, it really should have been split up into several PRs already. Reordering can be done in another PR after this is merged. If we can't get any movement on getting this merged, we can split it up into smaller PRs. That will allow the team to quickly review and okay changes. |
|
@elachlan thanks, I noticed the translation files have ". " Throughout should I open an issue? Latest merge from Master caused 80+ new issues and existing suppressions are not working, or names don't match new issues. Most of them are around UnsafeNativeMethods and NativeMethods that I don't want to remove in case someone wants to replace them with "shared primitives project and cswin32". Should I open issue? |
…icationServices/WindowsFormsApplicationBase.vb Co-authored-by: Lachlan Ennis <2433737+elachlan@users.noreply.github.com>
…icationServices/WindowsFormsApplicationBase.vb Co-authored-by: Lachlan Ennis <2433737+elachlan@users.noreply.github.com>
|
My comment about cswin32 is more for the winforms team. I think last time I mentioned it there were concerns raised. But I can't remember much. |
Add [CollectionDefinition("Sequential",DisableParallelization =true)] which prevents Clipboard tests from funning in parrallel with ANY othe collections.
Split ReferencedStream to dedicated file
…icationServices/WindowsFormsApplicationBase.vb Add period Co-authored-by: Lachlan Ennis <2433737+elachlan@users.noreply.github.com>
This reverts commit 3c20702.
This reverts commit a1e4949.
|
when you are merging master, are you rebasing? There are a few files that have changed in the PR which are irrelevant to the actual PR. |
That was an error, I thought I reverted the 2 commits. I could not find any way to cancel the commits accidentally to main. @elachlan please let me know if there are still issues with Main/master. All my changes should only be to my PR. |
|
In visual basic the namespace is made up of the rootnamespace in the project file plus the namespace inside the file. |
Yes I was actually at Master where it’s incorrect. VS was slow in updating Test Explorer when I switched branches. |
Fixes part of #10090
Standalone PR to do some cleanup of VB Code
Removes VB Option from source files and moves to Project File
Correct Spelling and Capitalization Errors
Add a few tests
Update editorConfig to support converting 3 NotInheritable classes to Modules.
Add a few tests
Change format of XLM Comment to indent text by 1 space
Change a few Private functions to Friend for testing
Not all issues are addressed in files I expect to replace.
Not done is reorganizing code in files to be in standard order, this will be a follow-on PR
Proposed changes
Fix above with very minimal code changes
Customer Impact
Regression?
No
Risk
Test methodology
Added tests where required otherwise covered by existing tests
Visual Basic only
Microsoft Reviewers: Open in CodeFlow