Code cleanup only and Add VB Tests

.editorconfig

@@ -494,7 +494,7 @@ dotnet_diagnostic.CA1070.severity = error
 # CA2016: Forward the CancellationToken parameter to methods that take one
 dotnet_diagnostic.CA2016.severity = warning
 
-# CA2020: Prevent behavioral change caused by built-in operators of IntPtr/UIntPtr 
+# CA2020: Prevent behavioral change caused by built-in operators of IntPtr/UIntPtr
 dotnet_diagnostic.CA2020.severity = warning
 
 # .NET diagnostic
@@ -595,6 +595,12 @@ visual_basic_preferred_modifier_order = Partial,Default,Private,Protected,Public
 
 dotnet_separate_import_directive_groups = false:warning
 
+# IDE0001: Simplify Names
+dotnet_diagnostic.IDE0001.severity = silent
+
+# IDE0002: Simplify Member Access
+dotnet_diagnostic.IDE0002.severity = silent
+
 # IDE0079: Remove unnecessary suppression
 dotnet_diagnostic.IDE0079.severity = none
 

eng/Version.Details.xml

@@ -1,9 +1,9 @@
 <?xml version="1.0" encoding="utf-8"?>
-<!-- 
-Dependencies registered here by Name and Uri will be updated by Maestro via darc update-dependencies 
-  They will be updated either in eng/Versions.props (most) or in global.json (for example: Microsoft.DotNet.Arcade.Sdk) 
-Note: if the Uri is a new place, you will need to add a subscription from that place to us in the appropriate channel 
-  And you can check these with "darc get-dependencies <dash dash>target-repo "winforms" 
+<!--
+Dependencies registered here by Name and Uri will be updated by Maestro via darc update-dependencies
+  They will be updated either in eng/Versions.props (most) or in global.json (for example: Microsoft.DotNet.Arcade.Sdk)
+Note: if the Uri is a new place, you will need to add a subscription from that place to us in the appropriate channel
+  And you can check these with "darc get-dependencies <dash dash>target-repo "winforms"
 -->
 <Dependencies>
   <ProductDependencies>

src/Microsoft.VisualBasic.Forms/src/Microsoft.VisualBasic.Forms.vbproj

@@ -1,15 +1,18 @@
-<Project>
+<Project>
   <!--
     https://github.com/dotnet/winforms/issues/2107#issuecomment-559289716
     https://github.com/microsoft/msbuild/issues/4923#issuecomment-554265394
     -->
   <Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" />
-  
+
   <PropertyGroup>
     <AssemblyName>Microsoft.VisualBasic.Forms</AssemblyName>
     <Deterministic>true</Deterministic>
+    <OptionExplicit>On</OptionExplicit>
+    <OptionInfer>Off</OptionInfer>
+    <OptionStrict>On</OptionStrict>
     <RootNamespace></RootNamespace>
-    <LangVersion>15.0</LangVersion>
+    <LangVersion>Latest</LangVersion>
     <VBRuntime>None</VBRuntime>
     <ProduceReferenceAssembly>true</ProduceReferenceAssembly>
     <UsePublicApiAnalyzers>true</UsePublicApiAnalyzers>

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/ApplicationServices/ApplicationBase.vb

@@ -1,24 +1,23 @@
 ' Licensed to the .NET Foundation under one or more agreements.
 ' The .NET Foundation licenses this file to you under the MIT license.
 
-Option Strict On
-Option Explicit On
+Imports System.Threading
 
 Imports ExUtils = Microsoft.VisualBasic.CompilerServices.ExceptionUtils
 
 Namespace Microsoft.VisualBasic.ApplicationServices
 
     ''' <summary>
-    ''' Abstract class that defines the application Startup/Shutdown model for VB
-    ''' Windows Applications such as console, WinForms, dll, service.
+    '''  Abstract class that defines the application Startup/Shutdown model for VB
+    '''  Windows Applications such as console, WinForms, dll, service.
     ''' </summary>
     Public Class ApplicationBase
 
         Public Sub New()
         End Sub
 
         ''' <summary>
-        ''' Returns the value of the specified environment variable.
+        '''  Returns the value of the specified environment variable.
         ''' </summary>
         ''' <param name="Name">A String containing the name of the environment variable.</param>
         ''' <returns>A string containing the value of the environment variable.</returns>
@@ -27,21 +26,23 @@ Namespace Microsoft.VisualBasic.ApplicationServices
         Public Function GetEnvironmentVariable(name As String) As String
 
             ' Framework returns Null if not found.
-            Dim VariableValue As String = Environment.GetEnvironmentVariable(name)
+            Dim variableValue As String = Environment.GetEnvironmentVariable(name)
 
             ' Since the explicitly requested a specific environment variable and we couldn't find it, throw
-            If VariableValue Is Nothing Then
-                Throw ExUtils.GetArgumentExceptionWithArgName("name", SR.EnvVarNotFound_Name, name)
+            If variableValue Is Nothing Then
+                Throw ExUtils.GetArgumentExceptionWithArgName(NameOf(name), SR.EnvVarNotFound_Name, name)
             End If
 
-            Return VariableValue
+            Return variableValue
         End Function
 
         ''' <summary>
-        ''' Provides access to logging capability.
+        '''  Provides access to logging capability.
         ''' </summary>
-        ''' <value>Returns a Microsoft.VisualBasic.Windows.Log object used for logging to OS log, debug window
-        ''' and a delimited text file or xml log.</value>
+        ''' <value>
+        '''  Returns a Microsoft.VisualBasic.Windows.Log object used for logging to OS log, debug window
+        '''  and a delimited text file or xml log.
+        ''' </value>
         Public ReadOnly Property Log() As Logging.Log
             Get
                 If _log Is Nothing Then
@@ -52,66 +53,69 @@ Namespace Microsoft.VisualBasic.ApplicationServices
         End Property
 
         ''' <summary>
-        ''' Returns the info about the application.  If we are executing in a DLL, we still return the info
-        ''' about the application, not the DLL.
+        '''  Returns the info about the application. If we are executing in a DLL, we still return the info
+        '''  about the application, not the DLL.
         ''' </summary>
         Public ReadOnly Property Info() As AssemblyInfo
             Get
                 If _info Is Nothing Then
-                    Dim Assembly As Reflection.Assembly = If(Reflection.Assembly.GetEntryAssembly(), Reflection.Assembly.GetCallingAssembly())
-                    _info = New AssemblyInfo(Assembly)
+                    Dim assembly As Reflection.Assembly = If(Reflection.Assembly.GetEntryAssembly(), Reflection.Assembly.GetCallingAssembly())
+                    _info = New AssemblyInfo(assembly)
                 End If
                 Return _info
             End Get
         End Property
 
         ''' <summary>
-        ''' Gets the information about the current culture used by the current thread.
+        '''  Gets the information about the current culture used by the current thread.
         ''' </summary>
         Public ReadOnly Property Culture() As Globalization.CultureInfo
             Get
-                Return Threading.Thread.CurrentThread.CurrentCulture
+                Return Thread.CurrentThread.CurrentCulture
             End Get
         End Property
 
         ''' <summary>
-        ''' Gets the information about the current culture used by the Resource
-        ''' Manager to look up culture-specific resource at run time.
+        '''  Gets the information about the current culture used by the Resource
+        '''  Manager to look up culture-specific resource at run time.
         ''' </summary>
         ''' <returns>
-        ''' The CultureInfo object that represents the culture used by the
-        ''' Resource Manager to look up culture-specific resources at run time.
+        '''  The CultureInfo object that represents the culture used by the
+        '''  Resource Manager to look up culture-specific resources at run time.
         ''' </returns>
         Public ReadOnly Property UICulture() As Globalization.CultureInfo
             Get
-                Return Threading.Thread.CurrentThread.CurrentUICulture
+                Return Thread.CurrentThread.CurrentUICulture
             End Get
         End Property
 
         ''' <summary>
-        ''' Changes the culture currently in used by the current thread.
+        '''  Changes the culture currently in used by the current thread.
         ''' </summary>
         ''' <remarks>
-        ''' CultureInfo constructor will throw exceptions if cultureName is Nothing
-        ''' or an invalid CultureInfo ID. We are not catching those exceptions.
+        '''  CultureInfo constructor will throw exceptions if cultureName is Nothing
+        '''  or an invalid CultureInfo ID. We are not catching those exceptions.
         ''' </remarks>
         Public Sub ChangeCulture(cultureName As String)
-            Threading.Thread.CurrentThread.CurrentCulture = New Globalization.CultureInfo(cultureName)
+            Thread.CurrentThread.CurrentCulture = New Globalization.CultureInfo(cultureName)
         End Sub
 
         ''' <summary>
-        ''' Changes the culture currently used by the Resource Manager to look
-        ''' up culture-specific resource at runtime.
+        '''  Changes the culture currently used by the Resource Manager to look
+        '''  up culture-specific resource at runtime.
         ''' </summary>
         ''' <remarks>
-        ''' CultureInfo constructor will throw exceptions if cultureName is Nothing
-        ''' or an invalid CultureInfo ID. We are not catching those exceptions.
+        '''  CultureInfo constructor will throw exceptions if cultureName is Nothing
+        '''  or an invalid CultureInfo ID. We are not catching those exceptions.
         ''' </remarks>
         Public Sub ChangeUICulture(cultureName As String)
-            Threading.Thread.CurrentThread.CurrentUICulture = New Globalization.CultureInfo(cultureName)
+            Thread.CurrentThread.CurrentUICulture = New Globalization.CultureInfo(cultureName)
         End Sub
 
-        Private _log As Logging.Log 'Lazy-initialized and cached log object.
-        Private _info As AssemblyInfo ' The executing application (the EntryAssembly)
+        'Lazy-initialized and cached log object.
+        Private _log As Logging.Log
+        ' The executing application (the EntryAssembly)
+        Private _info As AssemblyInfo
+
     End Class 'ApplicationBase
 End Namespace

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/ApplicationServices/ApplyApplicationDefaultsEventArgs.vb

@@ -1,10 +1,6 @@
 ' Licensed to the .NET Foundation under one or more agreements.
 ' The .NET Foundation licenses this file to you under the MIT license.
 
-Option Strict On
-Option Explicit On
-Option Infer On
-
 Imports System.ComponentModel
 Imports System.Drawing
 Imports System.Runtime.InteropServices
@@ -13,7 +9,7 @@ Imports System.Windows.Forms
 Namespace Microsoft.VisualBasic.ApplicationServices
 
     ''' <summary>
-    ''' Provides context for the ApplyApplicationDefaults event.
+    '''  Provides context for the ApplyApplicationDefaults event.
     ''' </summary>
     <EditorBrowsable(EditorBrowsableState.Advanced), ComVisible(False)>
     Public Class ApplyApplicationDefaultsEventArgs
@@ -26,25 +22,25 @@ Namespace Microsoft.VisualBasic.ApplicationServices
         End Sub
 
         ''' <summary>
-        ''' Setting this property inside the event handler causes a new default Font for Forms and UserControls to be set.
+        '''  Setting this property inside the event handler causes a new default Font for Forms and UserControls to be set.
         ''' </summary>
         ''' <remarks>
-        ''' When the ApplyApplicationDefault event is raised, this property contains nothing. A new default Font for the
-        ''' application is applied by setting this property with a value different than nothing.
+        '''  When the ApplyApplicationDefault event is raised, this property contains nothing. A new default Font for the
+        '''  application is applied by setting this property with a value different than nothing.
         ''' </remarks>
         Public Property Font As Font
 
         ''' <summary>
-        ''' Setting this Property inside the event handler determines how long an application's Splash dialog is displayed at a minimum.
+        '''  Setting this Property inside the event handler determines how long an application's Splash dialog is displayed at a minimum.
         ''' </summary>
         Public Property MinimumSplashScreenDisplayTime As Integer =
             WindowsFormsApplicationBase.MINIMUM_SPLASH_EXPOSURE_DEFAULT
 
         ''' <summary>
-        ''' Setting this Property inside the event handler determines the general HighDpiMode for the application.
+        '''  Setting this Property inside the event handler determines the general HighDpiMode for the application.
         ''' </summary>
         ''' <remarks>
-        ''' The default value for this property is SystemAware.
+        '''  The default value for this property is SystemAware.
         ''' </remarks>
         Public Property HighDpiMode As HighDpiMode