-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port TreeNodeCollectionEditor to core #11221
Port TreeNodeCollectionEditor to core #11221
Conversation
@LeafShi1 - do you need to update https://github.com/dotnet/winforms/blob/main/eng/Localize/LocProject.json with the new .xlf file? |
Yes, Done. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11221 +/- ##
===================================================
+ Coverage 73.47335% 74.29401% +0.82066%
===================================================
Files 3101 3010 -91
Lines 632447 625469 -6978
Branches 46688 46534 -154
===================================================
+ Hits 464680 464686 +6
+ Misses 164359 157368 -6991
- Partials 3408 3415 +7
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Had you tried editing specific nodes from property grid inside this dialog and see if the changes are persisted? For example change the node name or color.
Fixes #11198
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
There's an incorrect TreeNode Collection Editor dialog for TreeView control.
After
TreeNode Collection Editor dialog of the TreeView control show correct
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow