Simplify contributing guide #118
Conversation
Documentation/contributing-guide.md
Outdated
| @@ -1,37 +1,10 @@ | |||
| # Contributing Guide | |||
|
|
|||
| Primary focus of .NET Core 3.0 release is to achieve parity with WinForms for .NET Framework. | |||
| Since we're currently still porting parts of WinForms codebase (incl. tests) to GitHub, we're not ready to handle non-trivial or larger contributions beyond parity fixes yet. | |||
| The primary focus of .NET Core 3.0 release for Windows Forms is to achieve parity with with .NET Framework. Priority will be given to changes that align with that goal. | |||
There was a problem hiding this comment.
Nit: The doc tries to wrap on each line to avoid XL wide text.
There was a problem hiding this comment.
Is there a tool that we can use for that? I'm not going to do it manually.
There was a problem hiding this comment.
No, I don't have a tool. I do it manually. It simplifies diff reviews. It is similar to code style guidelines.
It's not blocking. If you don't have time to change it now, we can update it in future.
There was a problem hiding this comment.
What's the issue here? there are definitely tools for character counting each line in.
There was a problem hiding this comment.
Here's what I see
So I don't understand the issue?
There was a problem hiding this comment.
It's about the source code, not about how it is rendered ;) ... it's a nit, nothing blocking.
karelz
added
the
🚫 * NO-MERGE *
|
In the offline meeting we agreed to leave the section header "Developer Instructions" here with link to doc going into details. |
karelz
removed
the
🚫 * NO-MERGE *
Documentation/contributing-guide.md
Outdated
| * Test fixes, test improvements and new tests increasing code coverage. | ||
| * Infrastructure fixes and improvements, which are aligned with achieving our goal to ship high quality .NET Core 3.0 release. | ||
| * Bug fixes for differences between WinForms for .NET Core and .NET Framework. | ||
| * Infrastructure fixes and improvements. |
There was a problem hiding this comment.
We are looking for fixes to test infrastructure, not build infrastructure, should not we clarify Test infrastructure here?
richlander
force-pushed
the
contributing
branch
from
92bc775
to
599de69
Compare
richlander
force-pushed
the
contributing
branch
from
599de69
to
df69759
Compare
ghost
locked as resolved and limited conversation to collaborators
No description provided.