Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to non-stable #2386

Merged
merged 2 commits into from
Nov 19, 2019
Merged

Switch to non-stable #2386

merged 2 commits into from
Nov 19, 2019

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Nov 18, 2019

Contributes to #2387

Microsoft Reviewers: Open in CodeFlow

@RussKie RussKie requested a review from a team as a code owner November 18, 2019 23:48
@RussKie
Copy link
Member Author

RussKie commented Nov 18, 2019

@mmitche our yml is set to release/*. Do we need to change to release/3.*?
https://github.com/dotnet/winforms/blob/release/3.0/azure-pipelines.yml#L13-L21

@mmitche
Copy link
Member

mmitche commented Nov 18, 2019

@mmitche our yml is set to release/*. Do we need to change to release/3.*?
https://github.com/dotnet/winforms/blob/release/3.0/azure-pipelines.yml#L13-L21

No, release/* is fine.

@RussKie RussKie changed the title Switch your repo to non-stable Switch to non-stable Nov 18, 2019
@RussKie
Copy link
Member Author

RussKie commented Nov 18, 2019

Updated packages as well, while I am at it.

@RussKie
Copy link
Member Author

RussKie commented Nov 19, 2019

Updating packages terminally breaks the build, reverting the change.
image

@mmitche any ideas?

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #2386 into release/3.0 will increase coverage by 0.04293%.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##           release/3.0       #2386         +/-   ##
=====================================================
+ Coverage     26.12259%   26.16552%   +0.04293%     
=====================================================
  Files              804         804                 
  Lines           267841      267841                 
  Branches         38021       38021                 
=====================================================
+ Hits             69967       70082        +115     
+ Misses          192855      192738        -117     
- Partials          5019        5021          +2
Flag Coverage Δ
#Debug 26.16552% <ø> (+0.04293%) ⬆️
#production 26.16552% <ø> (+0.04293%) ⬆️
#test 100% <ø> (ø) ⬆️

@ghost
Copy link

ghost commented Nov 19, 2019

Hello @RussKie!

Because this pull request has the :octocat: automerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Nov 19, 2019

Apologies, while this PR appears ready to be merged, it looks like release/3.0 is a protected branch and I have not been granted permission to perform the merge.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to oblige

@ghost
Copy link

ghost commented Nov 19, 2019

Apologies, while this PR appears ready to be merged, it looks like release/3.0 is a protected branch and I have not been granted permission to perform the merge.

@RussKie RussKie merged commit e614342 into dotnet:release/3.0 Nov 19, 2019
@RussKie RussKie deleted the update branch November 19, 2019 02:16
@mmitche
Copy link
Member

mmitche commented Nov 19, 2019

Updating packages terminally breaks the build, reverting the change.
image

@mmitche any ideas?

Probably because it's stable inside those zip files. You should be able to change it to "3.0.1" after this morning.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants