-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated API #2798
Remove deprecated API #2798
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2798 +/- ##
==================================================
- Coverage 59.4119% 59.35974% -0.05216%
==================================================
Files 1243 1236 -7
Lines 431284 428762 -2522
Branches 38995 38757 -238
==================================================
- Hits 256234 254512 -1722
+ Misses 169639 168902 -737
+ Partials 5411 5348 -63
|
Business case approved at my level. LGTM |
- Remove the following API because they have been obsolete since .NET 2.0: * `StatusBar` * `StatusBarDrawItemEventArgs` * `StatusBarDrawItemEventHandler` * `StatusBarPanel` * `StatusBarPanelAutoSize` * `StatusBarPanelBorderStyle` * `StatusBarPanelClickEventArgs` * `StatusBarPanelClickEventHandler` * `StatusBarPanelStyle` Relates to #2091
a80955d
to
827db4f
Compare
@OliaG FYI |
@vatsan-madhavan FYI, I hope it doesn't affect WPF |
You can just test for it instead and avoid breaking things after merging them, and then have to worry about reverting them or needing the next-repo to do stuff in a hurry etc.
Or better yet, you can set up a couple of test branches on the internal Azure pipelines mirror repos to and use the build-pipelines to run the builds. For complex changes that might break the next repo, we do this sort of stuff proactively all the time. See this for example. /cc @rladuca |
Yes, an after thought on my part. |
Docs: dotnet/docs#17008 |
As identified in #2476 (comment)
Relates to #2091
Proposed changes
StatusBar
StatusBarDrawItemEventArgs
StatusBarDrawItemEventHandler
StatusBarPanel
StatusBarPanelAutoSize
StatusBarPanelBorderStyle
StatusBarPanelClickEventArgs
StatusBarPanelClickEventHandler
StatusBarPanelStyle
Customer Impact
Regression?
Yes/ NoRisk
Test methodology
Microsoft Reviewers: Open in CodeFlow