Remove deprecated API

[RussKie]

As identified in #2476 (comment)

Relates to #2091

Proposed changes

• Remove the following API because they have been obsolete since .NET 2.0:
  • StatusBar
  • StatusBarDrawItemEventArgs
  • StatusBarDrawItemEventHandler
  • StatusBarPanel
  • StatusBarPanelAutoSize
  • StatusBarPanelBorderStyle
  • StatusBarPanelClickEventArgs
  • StatusBarPanelClickEventHandler
  • StatusBarPanelStyle

Customer Impact

• Removed controls no longer available to customers and will cause builds to break
• Customers will need to replace the removed controls with available alternatives.

Regression?

• Yes / No

Risk

• Medium, the controls in questions have been deprecated in .NET 2.0 era, however there is a recorded use of those.

Test methodology

• TBD

Microsoft Reviewers: Open in CodeFlow

[codecov]

Codecov Report

Merging #2798 into master will decrease coverage by 0.05216%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             master       #2798         +/-   ##
==================================================
- Coverage   59.4119%   59.35974%   -0.05216%     
==================================================
  Files          1243        1236          -7     
  Lines        431284      428762       -2522     
  Branches      38995       38757        -238     
==================================================
- Hits         256234      254512       -1722     
+ Misses       169639      168902        -737     
+ Partials       5411        5348         -63

Flag	Coverage Δ
#Debug	59.35974% <ø> (-0.05217%)	⬇️
#production	32.12776% <ø> (-0.06927%)	⬇️
#test	98.97632% <ø> (+0.0049%)	⬆️

[merriemcgaw]

Business case approved at my level. LGTM

[RussKie]

@OliaG FYI

[RussKie]

@vatsan-madhavan FYI, I hope it doesn't affect WPF

[vatsan-madhavan]

FYI, I hope it doesn't affect WPF

You can just test for it instead and avoid breaking things after merging them, and then have to worry about reverting them or needing the next-repo to do stuff in a hurry etc.

• build you repo locally to get Microsoft.Private.Winforms.5.0.0-dev.nupkg under, say %winformsroot%\artifacts\packages\Debug\NonShipping
• clear nuget cache (nuget locals all -clear)
• clone dotnet/wpf (git clone https://github.com/dotnet/wpf)
  • edit NuGet.config and add a new source pointing to %winformsroot%\artifacts\packages\Debug\NonShipping
  • darc update-dependency -n Microsoft.Private.Winforms -v 5.0.0-dev
  • build wpf
  • build -pack -configuration Debug|Release -platform x86|x64

Or better yet, you can set up a couple of test branches on the internal Azure pipelines mirror repos to and use the build-pipelines to run the builds. For complex changes that might break the next repo, we do this sort of stuff proactively all the time. See this for example.

/cc @rladuca

[RussKie]

Yes, an after thought on my part.
Thank you for the instructions

[RussKie]

Docs: dotnet/docs#17008