Fix ANE in the "ListViewSubItemAccessibleObjectin" constructor (#4744) (port to 5.0) #4764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et#4744) Added missing logic for adding and removing owner. The problem is reproduced because when getting an accessibility object for a ListViewSubItem, the ListViewSubItem may not have an owner. This is because we have several ways to create and add an unowned ListViewSubItem to an ListViewItem. Added/updated unit tests
RussKie
approved these changes
Apr 6, 2021
|
Approved for servicing in #4744 |
Codecov Report
@@ Coverage Diff @@
## release/5.0 #4764 +/- ##
=====================================================
+ Coverage 68.41685% 68.43016% +0.01331%
=====================================================
Files 1421 1421
Lines 510880 511051 +171
Branches 41586 41587 +1
=====================================================
+ Hits 349528 349713 +185
+ Misses 154927 154916 -11
+ Partials 6425 6422 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
SergeySmirnov-Akvelon
deleted the
Issue_4742_ListViewSubItemAccessibleObject__ctor_ANE_5.0
branch
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4742
Proposed changes
ListViewSubItem, theListViewSubItemmay not have an owner. This is because we have several ways to create and add an unownedListViewSubItemto anListViewItem.Customer Impact
An app crash upon clicking on a listview subitem.
Before fix:
After fix:
Regression?
Risk
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow