Fix ANE in the "ListViewSubItemAccessibleObjectin " constructor #4744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4744 +/- ##
===================================================
+ Coverage 97.96231% 97.96348% +0.00117%
===================================================
Files 547 547
Lines 266036 266189 +153
Branches 5109 5109
===================================================
+ Hits 260615 260768 +153
Misses 4531 4531
Partials 890 890
Flags with carried forward coverage won't be shown. Click here to find out more. |
SergeySmirnov-Akvelon
added
📬 waiting-for-testing
RussKie
added
the
Servicing-consider
RussKie
reviewed
Mar 31, 2021
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ListViewSubItemCollectionTests.cs
Outdated
Show resolved
Hide resolved
RussKie
removed
the
waiting-review
SergeySmirnov-Akvelon
force-pushed
the
Issue_4742_ListViewSubItemAccessibleObject__ctor_ArgumentNullException
branch
from
a196638
to
55d9f02
Compare
dreddy-work
reviewed
Mar 31, 2021
src/System.Windows.Forms/src/System/Windows/Forms/ListViewItem.ListViewSubItemCollection.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListViewItem.ListViewSubItemCollection.cs
Outdated
Show resolved
Hide resolved
… ArgumentNullException dotnet#4742 The problem is reproduced because when getting an accessibility object for a ListViewSubItem, the ListViewSubItem may not have an owner. This is because we have several ways to create and add an unowned ListViewSubItem to an ListViewItem. Added missing logic for adding and removing owner. Added/updated unit tests
SergeySmirnov-Akvelon
force-pushed
the
Issue_4742_ListViewSubItemAccessibleObject__ctor_ArgumentNullException
branch
from
55d9f02
to
d8fde13
Compare
leecow
added
Servicing-approved
RussKie
approved these changes
Apr 6, 2021
SergeySmirnov-Akvelon
removed
the
📬 waiting-for-testing
RussKie
deleted the
Issue_4742_ListViewSubItemAccessibleObject__ctor_ArgumentNullException
branch
SergeySmirnov-Akvelon
added a commit
to SergeySmirnov-Akvelon/winforms
that referenced
this pull request
Apr 6, 2021
…et#4744) Added missing logic for adding and removing owner. The problem is reproduced because when getting an accessibility object for a ListViewSubItem, the ListViewSubItem may not have an owner. This is because we have several ways to create and add an unowned ListViewSubItem to an ListViewItem. Added/updated unit tests
dreddy-work
pushed a commit
that referenced
this pull request
Apr 7, 2021
… (#4764) Added missing logic for adding and removing owner. The problem is reproduced because when getting an accessibility object for a ListViewSubItem, the ListViewSubItem may not have an owner. This is because we have several ways to create and add an unowned ListViewSubItem to an ListViewItem. Added/updated unit tests
wreuel
pushed a commit
to wreuel/winforms
that referenced
this pull request
Apr 13, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4742
Proposed changes
ListViewSubItem, theListViewSubItemmay not have an owner. This is because we have several ways to create and add an unownedListViewSubItemto anListViewItem.Customer Impact
An app crash upon clicking on a listview subitem.
Before fix:
After fix:
Regression?
Risk
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow