Use system hand cursor, take 3 #525
Conversation
…ert-327-revert-138-master
sylveon
changed the title
|
The CI doesn't seems to actually work when this is a draft, so marking as ready for review. |
The CI is running. See checks and Azure Pipelines The WIP check is failing because of [WIP] in the title. |
|
No, Azure Pipelines was not building at all until I marked it ready for
review and pushed an empty commit.
|
|
That is strange. Perhaps because the PR began with [WIP] since creation? I am honestly unsure. |
sylveon
changed the title
|
I removed WIP from the title since the tests seems fine now anyways. |
|
@sylveon is this ready to go once any merge conflicts are resolved? |
…rt-327-revert-138-master
|
Yes, I've resolved them. |
|
The test failures have started showing up again 😓 |
|
My instinct is to hold on this until all our tests are on Helix. I think this is an issue with the state of the build machines, and once we get code coverage working on Helix machines, we can run all our tests (debug included) on those @sylveon |
|
Ok, I'll leave this PR open until then. |
|
@sylveon feel free to update this from master now that our tests are on isolated machines :) |
…rt-327-revert-138-master
Codecov Report
@@ Coverage Diff @@
## master #525 +/- ##
===================================================
+ Coverage 27.48178% 27.49073% +0.00895%
===================================================
Files 1055 1056 +1
Lines 291142 291149 +7
Branches 38521 38521
===================================================
+ Hits 80011 80039 +28
+ Misses 207077 207060 -17
+ Partials 4054 4050 -4
|
|
@zsd4yr merged with master and all tests passed :) |
|
aye fantastic @sylveon !! 🎥 take 3 is a winner! |
ghost
locked as resolved and limited conversation to collaborators
#328
This will probably need some changes, just creating this PR to run the tests.