Revert "Use system hand cursor, take 3 (#525)" #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 935d8d2.
|
@sylveon I'm sorry, this failed internal... System.ObjectDisposedException : Cannot access a disposed object.\r\nObject name: 'Disposed 'Cursor' can no longer be used.'.for all 28 example stacktrace at System.Windows.Forms.Cursor.get_Handle() in /_/src/System.Windows.Forms/src/System/Windows/Forms/Cursor.cs:line 228
at System.Windows.Forms.Tests.CursorsTests.Cursors_NotNullHandle(Cursor cursor) in /_/src/System.Windows.Forms/tests/UnitTests/Cursors.cs:line 28 |
zsd4yr
deleted the
dev/zadanz/revert-935d8d2488f7743d5a0996c1296f1d69986b146c
branch
|
Honestly, I don't really think those tests are essential or even needed. I only added them on request from another maintainer. If we could remove them, it would make the whole ordeal much easier. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 935d8d2.