added application manifest to the integration test binary in order to… #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ensure that we opt in into the latest windows features, such as accessible hih contrast colors
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
==========================================
- Coverage 27.97% 27.96% -0.01%
==========================================
Files 903 903
Lines 243518 243518
Branches 32091 32091
==========================================
- Hits 68121 68103 -18
- Misses 171572 171597 +25
+ Partials 3825 3818 -7
|
|
@Tanya-Solyanik what will this do if we run our integration tests on Windows 8.1 or Windows 7? |
JuditRose
reviewed
Mar 20, 2019
| and is designed to work with. Uncomment the appropriate elements | ||
| and Windows will automatically select the most compatible environment. --> | ||
|
|
||
| <!-- Windows Vista --> |
There was a problem hiding this comment.
Do we need all these commented out lines in this file?
There was a problem hiding this comment.
No, but this is a standard template added by the VS and we might want to experiment with different options later on. So I'd rather keep it.
@zsd4yr - it will still run on downlevel OS. This line enables certain fixes in Windows when this app is running on win10 but this is ignored otherwise.
JuditRose
approved these changes
Mar 22, 2019
|
thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… ensure that we opt in into the latest windows features, such as accessible hih contrast colors