Port ControlDesigner

[JuditRose]

Fixes #653
Related issues: #585, #221

Components copied from framework.

My dear reviewers: I am terribly sorry in advance for the number of lines...

[Tanya-Solyanik]

BitmapSelector is a VS/Blend feature, I would remove it. It required special resource dlls to work, I don't see devexpress using it... This could be a follow up issue. Invocation of this class should follow the path that loads resources from this dll, instead of redirecting to a dll with the same name and a special suffix.

[Tanya-Solyanik]

remove?

---

Refers to: src/Common/src/CompModSwitches.cs:13 in cd651fe. [](commit_id = cd651fe, deletion_comment = False)

[Tanya-Solyanik]

    public const string ExternDllUser32 = "user32.dll";

Don't we have a common file for these? ExternalDlls.cs?

---

Refers to: src/System.Windows.Forms.Design/src/System/ComponentModel/Design/DesignerActionPanel.cs:27 in cd651fe. [](commit_id = cd651fe, deletion_comment = False)

[Tanya-Solyanik]

#endif

this can be removed, we are not setting this macro anywhere

---

Refers to: src/System.Windows.Forms.Design/src/System/ComponentModel/Design/DesignerActionPanel.cs:72 in cd651fe. [](commit_id = cd651fe, deletion_comment = False)

[Tanya-Solyanik]

#endif

remove?

---

Refers to: src/System.Windows.Forms.Design/src/System/ComponentModel/Design/DesignerActionPanel.cs:243 in cd651fe. [](commit_id = cd651fe, deletion_comment = False)

[Tanya-Solyanik]

                form.Activated -= new EventHandler(OnFormActivated);

New eventNandler is not needed: form.Activated-=OnFormActivated;
The same applies across the file

---

Refers to: src/System.Windows.Forms.Design/src/System/ComponentModel/Design/DesignerActionPanel.cs:519 in cd651fe. [](commit_id = cd651fe, deletion_comment = False)

[Tanya-Solyanik]

            TypeDescriptor.Refreshed -= new RefreshEventHandler(OnComponentRefresh);

newEventHandle can be removed across the file

---

Refers to: src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ComponentTray.cs:871 in cd651fe. [](commit_id = cd651fe, deletion_comment = False)

[Tanya-Solyanik]

    /// <para>

para could be removed

---

Refers to: src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ComponentTray.cs:996 in cd651fe. [](commit_id = cd651fe, deletion_comment = False)

[Tanya-Solyanik]

This code does not look right. I wonder what it does when built for retail....
This is what ILSPY shows:
protected override void Dispose(bool disposing)
{
ISite site;
IComponentChangeService componentChangeService;
if (disposing)
{
site = component.Site;
if (site != null)
{
componentChangeService = (IComponentChangeService)site.GetService(typeof(IComponentChangeService));
if (!System.ComponentModel.CompModSwitches.CommonDesignerServices.Enabled)
{
goto IL_0048;
}
goto IL_0048;
}
}
goto IL_00b0;
IL_00b0:
base.Dispose(disposing);
return;
IL_008e:
IDictionaryService dictionaryService;
dictionaryService?.SetValue(typeof(TrayControl), null);
goto IL_00b0;
IL_0048:
if (componentChangeService != null)
{
componentChangeService.ComponentRename -= OnComponentRename;
}
dictionaryService = (IDictionaryService)site.GetService(typeof(IDictionaryService));
if (!System.ComponentModel.CompModSwitches.CommonDesignerServices.Enabled)
{
goto IL_008e;
}
goto IL_008e;
}

Indeed in retail build this executes like this:
if (CompModSwitches.CommonDesignerServices.Enabled)
{
if (cs != null)
{
cs.ComponentRename -= new ComponentRenameEventHandler(OnComponentRename);
}
}

because Debug class is conditionally compiled only in CHK build (/debug flag) I don't think this is a leak because this even is not static and will be disposed with this class. This:
if (CompModSwitches.CommonDesignerServices.Enabled) Debug.Assert(cs != null, "IComponentChangeService not found");
should be replaced with
Debug.Assert(!CompModSwitches.CommonDesignerServices.Enabled || (cs != null), "IComponentChangeService not found");
or something along these lines. And the same

---

Refers to: src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ComponentTray.cs:2056 in cd651fe. [](commit_id = cd651fe, deletion_comment = False)

[Tanya-Solyanik]

                        Debug.Assert(ds != null, "IDictionaryService not found");

and the same here, though this might be a leak... I opened a bug for VS.

---

Refers to: src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ComponentTray.cs:2059 in cd651fe. [](commit_id = cd651fe, deletion_comment = False)

[Tanya-Solyanik]

                    Debug.Assert(ds != null, "IDictionaryService not found");

same here

---

Refers to: src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ComponentTray.cs:2085 in cd651fe. [](commit_id = cd651fe, deletion_comment = False)

[Tanya-Solyanik]

                            Debug.Assert(sel != null, "ISelectionService not found");

oops

---

Refers to: src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ComponentTray.cs:2196 in cd651fe. [](commit_id = cd651fe, deletion_comment = False)

[Tanya-Solyanik]

                Debug.Assert(eps != null, "IEventBindingService not found");

oops

---

Refers to: src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ComponentTray.cs:2503 in cd651fe. [](commit_id = cd651fe, deletion_comment = False)

[Tanya-Solyanik]

            rc.DragDrop += new DragEventHandler(OnDragDrop);

new eventHandler could be removed across the file

---

Refers to: src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ControlDesigner.cs:625 in cd651fe. [](commit_id = cd651fe, deletion_comment = False)

[Tanya-Solyanik]

            // HACK HACK HACK

please remove

---

Refers to: src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ControlDesigner.cs:1323 in cd651fe. [](commit_id = cd651fe, deletion_comment = False)

[Tanya-Solyanik]

            throw new ArgumentNullException("component");

nameof

---

Refers to: src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DesignerActionService.cs:169 in cd651fe. [](commit_id = cd651fe, deletion_comment = False)

[Tanya-Solyanik]

            throw new ArgumentNullException("component");

nameof

---

Refers to: src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DesignerActionService.cs:192 in cd651fe. [](commit_id = cd651fe, deletion_comment = False)

[Tanya-Solyanik]

            throw new ArgumentNullException("actionLists");

nameof

---

Refers to: src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DesignerActionService.cs:197 in cd651fe. [](commit_id = cd651fe, deletion_comment = False)

[Tanya-Solyanik]

            throw new ArgumentNullException("actionLists");

nameof

---

Refers to: src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DesignerActionService.cs:301 in cd651fe. [](commit_id = cd651fe, deletion_comment = False)

[Tanya-Solyanik]

            throw new ArgumentNullException("actionList");

nameof

---

Refers to: src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DesignerActionService.cs:362 in cd651fe. [](commit_id = cd651fe, deletion_comment = False)

[Tanya-Solyanik]

            throw new ArgumentNullException("actionList");

nameof

---

Refers to: src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DesignerActionService.cs:387 in cd651fe. [](commit_id = cd651fe, deletion_comment = False)

[Tanya-Solyanik]

🕐

[codecov]

Codecov Report

Merging #681 into master will decrease coverage by 1.37247%.
The diff coverage is 0.13193%.

@@                 Coverage Diff                 @@
##              master        #681         +/-   ##
===================================================
- Coverage   25.91177%   24.53929%   -1.37248%     
===================================================
  Files            981        1026         +45     
  Lines         268488      284124      +15636     
  Branches       35935       38434       +2499     
===================================================
+ Hits           69570       69722        +152     
- Misses        195054      210499      +15445     
- Partials        3864        3903         +39

Flag	Coverage Δ
#Debug	24.53929% <0.13193%> (-1.37248%)	⬇️
#production	16.79516% <0.13193%> (-1.02244%)	⬇️
#test	98.55089% <ø> (-0.13552%)	⬇️

[JuditRose]

All comments addressed, BitMapSelector is removed.
Thanks for the review! :)

[Tanya-Solyanik]