Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port DateTimePickerDesigner to runtime #8549

Conversation

dmitrii-drobotov
Copy link
Contributor

@dmitrii-drobotov dmitrii-drobotov commented Feb 1, 2023

Related to #8501, #8508, #2411

Proposed changes

  • Port DateTimePickerDesigner to runtime

Customer Impact

  • DateTimePicker can be designed in runtime

Regression?

  • No

Risk

  • Minimal

Screenshots

Before

Screenshot 2023-02-01 133438

DateTimePicker is not available in runtime designer scenario

After

datetimepickerdesigner

DateTimePicker can be designed in runtime

Test methodology

  • Manually (added DateTimePicker to DemoConsole test app)

Test environment(s)

  • .NET 8.0.0-alpha.1.23067.11
  • Windows 10.0.22621
Microsoft Reviewers: Open in CodeFlow

@dmitrii-drobotov dmitrii-drobotov self-assigned this Feb 1, 2023
@dmitrii-drobotov dmitrii-drobotov requested a review from a team as a code owner February 1, 2023 14:50
@dmitrii-drobotov dmitrii-drobotov added the waiting-review This item is waiting on review by one or more members of team label Feb 1, 2023
@dmitrii-drobotov dmitrii-drobotov force-pushed the Issue_8508_Port_DateTimePickerDesigner branch from 4078203 to 112156e Compare February 1, 2023 15:36
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion otherwise looks good!

@elachlan
Copy link
Contributor

elachlan commented Feb 2, 2023

Cool! Great work!

@dreddy-work dreddy-work enabled auto-merge (squash) February 3, 2023 01:20
@dreddy-work dreddy-work merged commit 80c38d5 into dotnet:main Feb 3, 2023
@ghost ghost added this to the 8.0 Preview1 milestone Feb 3, 2023
@dmitrii-drobotov dmitrii-drobotov deleted the Issue_8508_Port_DateTimePickerDesigner branch February 3, 2023 11:48
@ghost ghost locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
waiting-review This item is waiting on review by one or more members of team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants