-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port DataGridviewDesigner to runtime #9677
Port DataGridviewDesigner to runtime #9677
Conversation
d1d524b
to
015e4d3
Compare
015e4d3
to
44a4d4e
Compare
18b1fb8
to
c048d14
Compare
c048d14
to
5b02b83
Compare
cf300d4
to
f0c305a
Compare
f0c305a
to
5fc4031
Compare
src/System.Windows.Forms.Design/src/System.Windows.Forms.Design.csproj
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/BindingSourceDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/BindingSourceDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/BindingSourceDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DataGridViewAddColumnDialog.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DataGridViewAddColumnDialog.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DataGridViewAddColumnDialog.cs
Outdated
Show resolved
Hide resolved
return true; | ||
} | ||
|
||
private class ListBoxItem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this class to a dedicated file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these classes were nested before, they should stay nested. I meant extracting each small class into a small file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes , there are nested before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please move these classes into dedicated files. You should name these new files like this - DataGridViewAddColumnDialog.ListBoxItem.cs. You will have to declare DataGridViewAddColumnDialog as partial class. See https://github.com/dotnet/winforms/blob/main/src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ControlDesigner.ChildSubClass.cs for an example.
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DataGridViewAddColumnDialog.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/DataGridView.cs
Outdated
Show resolved
Hide resolved
c091cc4
to
330d2a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
src/System.Windows.Forms.Primitives/src/System/Windows/Forms/Internals/DpiHelper.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DataGridViewAddColumnDialog.cs
Outdated
Show resolved
Hide resolved
6a3790e
to
95289e7
Compare
….com/Epica3055/winforms into Issue_4908_Port_DataGridViewDesigner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@@ -19,7 +19,7 @@ internal class TableLayoutPanelBehavior : Behavior | |||
private BehaviorService behaviorService; //used for bounds translation | |||
private IServiceProvider serviceProvider; //cached to allow our behavior to get services | |||
private TableLayoutPanelResizeGlyph tableGlyph; //the glyph being resized | |||
private DesignerTransaction resizeTransaction; //used to make size adjustements within transaction | |||
private DesignerTransaction resizeTransaction; //used to make size adjustments within transaction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
We ported DataGridviewDesigner via #9677 LocProj need to be updated to fix issue in CI https://dev.azure.com/dnceng/internal/_build/results?buildId=2266578&view=logs&j=c2111129-d6a3-58de-e667-00e5a0966c99&t=04624205-1088-500d-206a-392ceb108efa
Related to #4908
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow