Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup to WPF to adapt to removal of legacy API's from WinForms #2168

Merged

Conversation

vatsan-madhavan
Copy link
Member

@vatsan-madhavan vatsan-madhavan commented Nov 8, 2019

Description

Fixes #2169

This is a fixup to WPF to adapt to legacy api removal in WinForms (see dotnet/winforms#2157).

Risk

Low - minor changes to ElementHost.

Customer Impact.

Doesn't seem like very much of an impact from WPF directly. Indirect impact from WinForms changes are off-topic here.

Testing

None - this builds.

Related: We need this to get #2161 going.

/cc @RussKie

@ghost ghost requested a review from rladuca November 8, 2019 01:25
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Nov 8, 2019
@ghost ghost requested a review from SamBent November 8, 2019 01:25
@vatsan-madhavan vatsan-madhavan self-assigned this Nov 8, 2019
@vatsan-madhavan vatsan-madhavan added this to the 3.1 milestone Nov 8, 2019
@vatsan-madhavan vatsan-madhavan added ask-mode * NO MERGE * metadata: The PR is not ready for merge yet (see discussion for detailed reasons) labels Nov 8, 2019
@vatsan-madhavan vatsan-madhavan removed the * NO MERGE * metadata: The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 8, 2019
@vatsan-madhavan vatsan-madhavan merged commit e201dee into dotnet:release/3.1 Nov 8, 2019
@vatsan-madhavan vatsan-madhavan deleted the winforms-apireduction-fixup branch November 8, 2019 03:07
@ghost ghost locked as resolved and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ask-mode PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants