Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup to WPF to adapt to removal of legacy API's from WinForms #2168

Merged

Conversation

@vatsan-madhavan
Copy link
Member

vatsan-madhavan commented Nov 8, 2019

Description

Fixes #2169

This is a fixup to WPF to adapt to legacy api removal in WinForms (see dotnet/winforms#2157).

Risk

Low - minor changes to ElementHost.

Customer Impact.

Doesn't seem like very much of an impact from WPF directly. Indirect impact from WinForms changes are off-topic here.

Testing

None - this builds.

Related: We need this to get #2161 going.

/cc @RussKie

@msftbot msftbot bot requested a review from rladuca Nov 8, 2019
@msftbot msftbot bot added the PR label Nov 8, 2019
@msftbot msftbot bot requested a review from SamBent Nov 8, 2019
@vatsan-madhavan vatsan-madhavan self-assigned this Nov 8, 2019
@vatsan-madhavan vatsan-madhavan added this to the 3.1 milestone Nov 8, 2019
@RussKie
RussKie approved these changes Nov 8, 2019
@rladuca
rladuca approved these changes Nov 8, 2019
@vatsan-madhavan vatsan-madhavan merged commit e201dee into dotnet:release/3.1 Nov 8, 2019
8 checks passed
8 checks passed
WIP Ready for review
Details
auto-merge.config.enforce No dynamic merge policies are applicable.
dotnet-wpf CI Build #20191107.7 succeeded
Details
dotnet-wpf CI (Build Windows_NT Build_Debug_x64) Build Windows_NT Build_Debug_x64 succeeded
Details
dotnet-wpf CI (Build Windows_NT Build_Debug_x86) Build Windows_NT Build_Debug_x86 succeeded
Details
dotnet-wpf CI (Build Windows_NT Build_Release_x64) Build Windows_NT Build_Release_x64 succeeded
Details
dotnet-wpf CI (Build Windows_NT Build_Release_x86) Build Windows_NT Build_Release_x86 succeeded
Details
license/cla All CLA requirements met.
Details
@vatsan-madhavan vatsan-madhavan deleted the wpfcontrib:winforms-apireduction-fixup branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.