Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix raw stylus data to support per-monitor DPI #2891

Merged
merged 9 commits into from
Aug 24, 2020
Merged

Fix raw stylus data to support per-monitor DPI #2891

merged 9 commits into from
Aug 24, 2020

Conversation

rladuca
Copy link
Member

@rladuca rladuca commented Apr 15, 2020

Related #2072

@rladuca rladuca requested a review from a team as a code owner April 15, 2020 20:07
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Apr 15, 2020
@ghost ghost requested review from fabiant3, ryalanms and vatsan-madhavan April 15, 2020 20:07
@rladuca
Copy link
Member Author

rladuca commented Apr 15, 2020

Should port this to 3.1 as well.

@ghost ghost requested a review from SamBent April 15, 2020 20:07
@rladuca rladuca self-assigned this Apr 15, 2020
@rladuca rladuca added the Bug Product bug (most likely) label Apr 15, 2020
@rladuca
Copy link
Member Author

rladuca commented Apr 15, 2020

This can also be considered for a 4.8 fix (it's a per-mon DPI miss). We should discuss that.

@rladuca rladuca added this to the 5.0 milestone Apr 15, 2020
@rladuca rladuca removed their assignment May 26, 2020
@rladuca
Copy link
Member Author

rladuca commented Jul 31, 2020

@ryalanms Just a ping on this, it blocks inking from working properly in per-monitor DPI scenarios.

@rladuca rladuca mentioned this pull request Aug 21, 2020
Open
@ryalanms ryalanms merged commit 0d45071 into dotnet:master Aug 24, 2020
@dotMorten
Copy link
Contributor

Thanks for the merge!

This can also be considered for a 4.8 fix (it's a per-mon DPI miss). We should discuss that.

Was this discussed / done? If so I need to do a version-check and remove my workaround for newer frameworks.

@ryalanms ryalanms mentioned this pull request Sep 2, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lindexi lindexi lindexi approved these changes

@ryalanms ryalanms ryalanms approved these changes

@fabiant3 fabiant3 Awaiting requested review from fabiant3

@vatsan-madhavan vatsan-madhavan Awaiting requested review from vatsan-madhavan

@SamBent SamBent Awaiting requested review from SamBent

Assignees
No one assigned
Labels
Bug Product bug (most likely) PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rladuca @dotMorten @lindexi @ryalanms