Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the custom HashSet class #3738

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Remove the custom HashSet class #3738

merged 1 commit into from
Jul 13, 2022

Conversation

lindexi
Copy link
Contributor

@lindexi lindexi commented Nov 5, 2020 •
edited
Loading

We've already used System.Collections.Generic.HashSet in NameFixupGraph and ObjectWriterFrame, etc

@lindexi lindexi requested a review from a team as a code owner November 5, 2020 11:47
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Nov 5, 2020
@ghost ghost requested review from fabiant3, ryalanms and SamBent November 5, 2020 11:47
lindexi added a commit to lindexi/lindexi_gd that referenced this pull request Nov 5, 2020
@lindexi
Remove the custom HashSet class
097f76f 
dotnet/wpf#3738
@ryalanms
Copy link
Member

ryalanms commented Feb 8, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Base automatically changed from master to main March 17, 2021 17:38
@lindexi
Copy link
Contributor Author

lindexi commented Mar 31, 2022

@anjalisheel-wpf Could you review my code?

@lindexi
Copy link
Contributor Author

lindexi commented Apr 7, 2022

@singhashish-wpf Could you review my code?

This was referenced Jun 1, 2022
Merged
Open
@ghost ghost assigned lindexi Jul 8, 2022
@singhashish-wpf
Copy link
Member

This PR is being considered for next community test pass.

@singhashish-wpf singhashish-wpf merged commit 9526c3a into dotnet:main Jul 13, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fabiant3 fabiant3 Awaiting requested review from fabiant3

@ryalanms ryalanms Awaiting requested review from ryalanms

@SamBent SamBent Awaiting requested review from SamBent

Assignees

@lindexi lindexi

Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
WPF Community Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lindexi @ryalanms @singhashish-wpf @dipeshmsft