-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix create BitmapDecoder with async file stream. #4966
Fix create BitmapDecoder with async file stream. #4966
Conversation
[BitmapDecoder.Create does not handle FileStream with FileOptions.Asynchronous · Issue dotnet#4355 · dotnet/wpf](dotnet#4355 )
Ping @vishalmsft |
Thank you @lindexi for the PR. The fix looks to work, as discussed in the relevant issue. Please let me know, if you need any help with adding the test there. It is just about adding one new WPF project and then adding the executable entry in the xml file. |
@vishalmsft Thank you. And I added the Test case in dotnet/wpf-test#14 But I need your help reviewing my test code. |
We have taken this PR for the current Community Test Pass. Thanks for the contribution. |
Thank you @dipeshmsft And can you review my test PR: dotnet/wpf-test#14 |
Regarding the test PR, we would have to wait for a little. The test may need to be in a different area ( the tests are divided into areas and subareas ), so once, we have all the areas there ( only a few DRTs are remaining ), we will have a discussion on that and go ahead with the test PR. |
Thank you @dipeshmsft |
Fixes Issue #4355
Description
Fix #4355
Customer Impact
Regression
Testing
Just CI and my demo: https://github.com/lindexi/lindexi_gd/tree/20b78c5547b2ecacdd244a438ef58518469a91d7/GeafakaijawkeheahemLejeehocear
Risk