Surround Keyboard Datagrid F3 sort with switch

[singhashish-wpf]

Fixes #7288

Main PR #6873

Description

F3 sort on Datagrid was causing compatibility issues. Surrounding the F3 datagrid sort feature around an opt Out switch.

Customer Impact

Customers can run into problem with F3 handling in datagrid scenarios. Unintended sorting rather than a specifically expected behaviour.

Regression

Yes

Testing

Local testing by sample datagrid app.

Risk

Low

Microsoft Reviewers: Open in CodeFlow

[zlatanov]

opt opt switch

Is this opt in or opt out feature? Looking at the changes it seems to be opt in?

[singhashish-wpf]

opt opt switch

Is this opt in or opt out feature? Looking at the changes it seems to be opt in?

Opt Out. Default is set to true. If you need to opt out then you need to disable in the config.

[batzen]

So AppContext.TryGetSwitch sets it's out param to true by default? The documentation says it's false if the switch is not found.

Aren't switches like this supposed to have a prefix hinting at WPF?

[singhashish-wpf]

So AppContext.TryGetSwitch sets it's out param to true by default? The documentation says it's false if the switch is not found.

Aren't switches like this supposed to have a prefix hinting at WPF?

It was wrongly assumed that the variable won't be updated in case the switch doesn't exist, however as you said it is set to false. So modified the code to update the switch name and the condition.

[zlatanov]

DataGridKeyboardSortFeature isn't really descriptive of what this switch is being used for in my opinion. It doesn't indicate that we expect a bool, or if it does if true means enable or disable.

[zlatanov]

Also, shouldn't you make IsDataGridKeyboardSortDisabled readonly?

[Kuldeep-MS]

The changes of this PR will be taken care by #7349