.NET Core #96
Merged
.NET Core #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… .net core as it is in framework. Also, the underlying byte array could be used for serialization.
…h to test file and adjust api for changes to PacketDotNet that have occurred since this test was last running.
For details see 713b2e5.
|
@Phyxion I'd like to do something with echo/obsolete because its annoying seeing warnings about usage inside of the library itself :-) |
|
I think the Obsolute attribute should just be removed. It's just for parsing anyway and while RFC says it's obsolete, it can still be parsed. |
…t still in use it is still possible that someone may want to parse a captured packet stream with packets that contain these flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This'll make the compare a little easier.