Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project Designer throws error with php7: Parse error: syntax error, unexpected 'new' (T_NEW) in ...projectdesigner/vw_tasks.php on line 112 #37

Closed
cleary opened this issue Nov 26, 2018 · 3 comments
Closed

Project Designer throws error with php7: Parse error: syntax error, unexpected 'new' (T_NEW) in ...projectdesigner/vw_tasks.php on line 112 #37

cleary opened this issue Nov 26, 2018 · 3 comments

Comments

@cleary
Copy link
Contributor

cleary commented Nov 26, 2018

Hi Adam,
Just testing PHP7 during this migration - project designer is giving me the following error:
Parse error: syntax error, unexpected 'new' (T_NEW) in /data/srv/debortoli.private/dotProject.git/modules/projectdesigner/vw_tasks.php on line 112

screenshot_20181126_163020

It's not present with PHP5.4
@ajdonnison
Copy link
Contributor

Yeah, looks like there are some assign-by-reference calls that haven't really been necessary for quite some time. I believe removing them won't break 5 - at least from 5.3 onwards. I'll make some changes and see if I can get that sorted out today.

ajdonnison added a commit that referenced this issue Nov 26, 2018
@ajdonnison
Fix #37 - old-style assign by reference
9b64ca3
@ajdonnison
Copy link
Contributor

Pull from devel again - that should fix the issue.

@cleary
Copy link
Contributor Author

cleary commented Nov 27, 2018

That's working well - thanks

@cleary cleary closed this as completed Nov 27, 2018
@cleary cleary mentioned this issue Nov 27, 2018
Closed
@cleary cleary mentioned this issue May 14, 2019
Merged
cleary referenced this issue in DeBortoliWines/dotProject May 14, 2019
@ajdonnison @cleary
Fix #37 - old-style assign by reference
d2857ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajdonnison @cleary