Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The presence of npm-shrinkwrap.json making shrink wrapping fail at the root module #7

Closed
sravanrekandar opened this issue Apr 28, 2017 · 2 comments

Comments

@sravanrekandar
Copy link

sravanrekandar commented Apr 28, 2017

Hi.
Thanks for providing this module.
Problem:
I am maintaining npm-shrinkwrap.json in my application. Now if I try install nodemailer-mock, my application's shrink wrapping is failing by giving many extraneous errors.
Example error:
npm WARN saveError extraneous: lodash.keys@3.1.2 /Users/sravankumarrekandar/workarea/nodemailer-test/node_modules/nodemailer-mock/node_modules/lodash.keys
..
The issue was fixed when I deleted both my-app/node_modules/nodemailer-mock/node_modules and my-app/node_modules/nodemailer-mock/npm-shrinkwrap.json
Then reinstalled my-app dependencies.
And everything is working fine.

However, we cannot maintain the hack. Please make sure the module is compatible with other apps.

Thanks.

@doublesharp
Copy link
Owner

doublesharp commented May 2, 2017 via email

@doublesharp
Copy link
Owner

The npm-shrinkwrap.json file has been removed in version 1.2.2.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants