-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted zero/max buttons to +-10 buttons #21
Conversation
Also added functionality to take all loot of a type at once when you have to drop items. Let me know if this is a useful addition. |
I'm not exactly sure how the Take All button functions... For example: I'm wandering the world with a full bag, and I want to pick up some Cured Meat from a pile of 10. If I click on the Cured Meat, the "drop" dropdown appears, now with the Take All option at the top. What is expected to happen if I click Take All? Right now, apparently nothing? I do like the idea of a Take All option, but I'm not sure it belongs in this dropdown. |
So the pain point Take All is meant to fix is the following: When you want to pick up lots of things quickly and have enough space, this is fast and easy: just click the button rapidly. However, as soon as you run out of space, it gets really slow: you have to keep on selecting things to drop. For example, finding 10 cured meat and wanting to replace your 10 cloth with them feels like it takes forever. So "take all" turns up when there's not enough space to pick up an item. If you click it, it reopens the drop menu, but this time with drop quantities high enough for then taking all items. So if there's still 5 cured meat left on the floor, and you have 5 cloth, it will say cloth x5 and let you switch them out all at once. ("This is a bad way of fixing this pain point" is a valid response. :D) |
Ahaaaaaa, I get it now. I agree that this change addresses a problem in the UI, but it's not terribly intuitive (as evidenced by my confusion). The worst part is, I'm not entirely sure how to solve this problem in an intuitive manner. |
Agreed. Because of slight git fail, this pull request contains both this feature and a perfectly good fix to the up/down buttons. I'll look into fixing that. |
OK, this pull request now only converts the zero/max buttons to +-10 buttons. |
Converted zero/max buttons to +-10 buttons
Woo! Now working on medicine. |
As discussed in email, the big buttons now do +-10. I've also made the code a bit more generic and hence shorter. :)