Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing directive #643

Merged
merged 1 commit into from
Dec 10, 2022
Merged

fix: missing directive #643

merged 1 commit into from
Dec 10, 2022

Conversation

lst97
Copy link
Contributor

@lst97 lst97 commented Dec 8, 2022

Description

FIX: Missing required directive in edit-profile-form.component.html

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from @macite and @jakerenzella on the Pull Request

@jakerenzella
Copy link
Member

@lst97 is last name required on the backend? I think there people with names who don't have surnames. If the backend requires it then this PR can be approved (but perhaps we need to fix the backend in that case)

@lst97
Copy link
Contributor Author

lst97 commented Dec 10, 2022

@lst97 is last name required on the backend? I think there people with names who don't have surnames. If the backend requires it then this PR can be approved (but perhaps we need to fix the backend in that case)

@jakerenzella Yes, it is required from backend, see issue: #644

@jakerenzella jakerenzella merged commit decf590 into doubtfire-lms:development Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants