Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add IsPrepared to SQLExpression interface #231

Merged
merged 1 commit into from Sep 17, 2020
Merged

add IsPrepared to SQLExpression interface #231

merged 1 commit into from Sep 17, 2020

Conversation

vlanse
Copy link
Contributor

@vlanse vlanse commented Aug 29, 2020

looks like it was not added accidentally in initial version :) anyway, it's convenient to have, I have at least one real use case where I need to know whether expression is prepared or not

@codecov
Copy link

codecov bot commented Aug 29, 2020

Codecov Report

Merging #231 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files          60       60           
  Lines        4189     4195    +6     
=======================================
+ Hits         4043     4049    +6     
  Misses        131      131           
  Partials       15       15           
Impacted Files Coverage Δ
exp/exp.go 68.49% <ø> (ø)
sql_dialect.go 100.00% <0.00%> (ø)
dialect/sqlite3/sqlite3.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 417f438...cb8524d. Read the comment docs.

@doug-martin doug-martin merged commit 92ef98f into doug-martin:master Sep 17, 2020
doug-martin added a commit that referenced this pull request Sep 17, 2020
* [FIXED] SELECT inherits dialect from INSERT in INSERT FROM SELECT.  #229, #223 - @vlanse
* [FIXED] SQLServer dialect: support prepared statements with TOP.  #230, #225 - @vlanse
* [ADDED] IsPrepared to SQLExpression interface.  #231 - @vlanse
@doug-martin doug-martin mentioned this pull request Sep 17, 2020
doug-martin added a commit that referenced this pull request Sep 17, 2020
* [FIXED] SELECT inherits dialect from INSERT in INSERT FROM SELECT.  #229, #223 - @vlanse
* [FIXED] SQLServer dialect: support prepared statements with TOP.  #230, #225 - @vlanse
* [ADDED] IsPrepared to SQLExpression interface.  #231 - @vlanse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants