Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix SQLServer dialect: support prepared statements with TOP, closes #225 #230

Merged
merged 1 commit into from
Sep 17, 2020
Merged

fix SQLServer dialect: support prepared statements with TOP, closes #225 #230

merged 1 commit into from
Sep 17, 2020

Conversation

vlanse
Copy link
Contributor

@vlanse vlanse commented Aug 29, 2020

Added one more dialect property to be consistent with current approach (but placeholder with format for LIMIT fragment looked better IMHO)

@codecov
Copy link

codecov bot commented Aug 29, 2020 •
edited
Loading

Codecov Report

Merging #230 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   96.51%   96.52%           
=======================================
  Files          60       60           
  Lines        4189     4200   +11     
=======================================
+ Hits         4043     4054   +11     
  Misses        131      131           
  Partials       15       15
Impacted Files Coverage Δ
sqlgen/sql_dialect_options.go 100.00% <ø> (ø)
dialect/sqlserver/sqlserver.go 100.00% <100.00%> (ø)
sqlgen/common_sql_generator.go 100.00% <100.00%> (ø)
sql_dialect.go 100.00% <0.00%> (ø)
dialect/sqlite3/sqlite3.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 417f438...2e57e73. Read the comment docs.

@vlanse
Copy link
Contributor Author

vlanse commented Sep 7, 2020 •
edited
Loading

@doug-martin any chance to merge this (and other) PRs and release a new version?
or maybe there are any changes I need to make?

@doug-martin
Copy link
Owner

@vlanse yep! I'll review and try to get your PRs out this week.

@doug-martin doug-martin merged commit 666f7a8 into doug-martin:master Sep 17, 2020
doug-martin added a commit that referenced this pull request Sep 17, 2020
@doug-martin
v9.10.0
bea1557 
* [FIXED] SELECT inherits dialect from INSERT in INSERT FROM SELECT.  #229, #223 - @vlanse
* [FIXED] SQLServer dialect: support prepared statements with TOP.  #230, #225 - @vlanse
* [ADDED] IsPrepared to SQLExpression interface.  #231 - @vlanse
@doug-martin doug-martin mentioned this pull request Sep 17, 2020
Merged
doug-martin added a commit that referenced this pull request Sep 17, 2020
@doug-martin
v9.10.0
865b53c 
* [FIXED] SELECT inherits dialect from INSERT in INSERT FROM SELECT.  #229, #223 - @vlanse
* [FIXED] SQLServer dialect: support prepared statements with TOP.  #230, #225 - @vlanse
* [ADDED] IsPrepared to SQLExpression interface.  #231 - @vlanse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doug-martin doug-martin doug-martin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlanse @doug-martin