Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website doesn't have a meta description #409

Closed
doug-wade opened this issue Aug 12, 2023 · 3 comments
Closed

Website doesn't have a meta description #409

doug-wade opened this issue Aug 12, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers website

Comments

@doug-wade
Copy link
Owner

doug-wade commented Aug 12, 2023 •
edited
Loading

I ran the Chrome lighthouse report, and it gave me an SEO error:

Meta descriptions may be included in search results to concisely summarize page content. Learn more about the meta description.

This is a screenshot of the issue quoted above
@doug-wade doug-wade added enhancement New feature or request good first issue Good for newcomers website labels Aug 12, 2023
@doug-wade
Copy link
Owner Author

doug-wade commented Aug 12, 2023 •
edited
Loading

We'll want to add the description here: https://github.com/doug-wade/tybalt/blob/master/packages/website/index.html#L11

We can use the tagline

a toolkit for creating web components

or you can propose another description!

This was referenced Aug 12, 2023
Merged
Merged
dougy-fresh added a commit to dougy-fresh/tybalt that referenced this issue Aug 13, 2023
@dougy-fresh
fix(doug-wade#409): use boring-er double quotes
ff1a4d0
@doug-wade
Copy link
Owner Author

Looks like our first try at this didn't work because we used the fancy double-quotes

Screenshot 2023-08-12 at 9 07 15 PM

doug-wade pushed a commit that referenced this issue Aug 13, 2023
@dougy-fresh @doug-wade
fix(#409): use boring-er double quotes
a29daee
@conorvenus
Copy link
Contributor

Oh that's my bad! 😄

I am pretty sure I just copied it off the Lighthouse reference link and changed the description, strange why it used a different Unicode character for the double quotes. 🤔

Thanks for the second fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers website
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@doug-wade @conorvenus