-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#170): Add cypress tests #412
Conversation
@@ -0,0 +1,17 @@ | |||
const { setupNodeEvents } = require('@tybalt/cypress'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this into packages/cypress? https://docs.cypress.io/guides/guides/command-line#cypress-run-config-file-lt-configuration-file-gt
CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }} | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have a record key?
What's the cypress cloud organization url? It's hard to debug without seeing what actually was ran.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I can, actually. When I read the message
Your CI provider is likely not passing private environment variables to builds from forks.
I think what's happening is that the account that is doing this pr (@dougy-fresh ) and the account that owns the repository (@doug-wade ) are two different accounts, and the one doesn't get the tokens from the other. I don't think we can use cloud. Does that mean we can't use cypress at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.cypress.io/pricing/
There is a limited free tier.
Cypress Cloud is essentially required to do anything with CI/CD because you can't view what happened in the test run.
It looks like you got something working with cloud when running it local.
The fact that the github action run mentions extra tabs error means there is something different going on and we'd need the video recording to get an idea about it.
Disparity between local and CI run environments is very common.
@@ -6,20 +6,22 @@ | |||
"scripts": { | |||
"build": "turbo build", | |||
"clean": "turbo clean", | |||
"e2e": "cypress run --browser=chrome", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd add --headless
just to make sure it isn't using a headed version and causing issues.
There is allegedly a --headless=new
to use the new version of chrome headless but it hasn't worked for me yet. Trying to find out about how it's used.
bfbed5c
to
b87c8e1
Compare
Thanks for your help @Ginsusamurai ! These commits landed in #521 |
I only tested index.html and the core documentation, but it'll at least check that the website comes up.
Fixes #170