Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#134): use setAttribute rather than doing a full re-render #551

Merged
merged 4 commits into from
Dec 17, 2023

Conversation

doug-wade
Copy link
Owner

No description provided.

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (ef6d01c) 89.44% compared to head (b6dcf68) 89.15%.

Files Patch % Lines
packages/core/src/api/define-component.ts 83.78% 6 Missing ⚠️
packages/core/src/api/render.ts 95.58% 3 Missing ⚠️
packages/reactive/src/api/reactive.ts 94.87% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
- Coverage   89.44%   89.15%   -0.29%     
==========================================
  Files          42       45       +3     
  Lines         947     1097     +150     
  Branches      169      204      +35     
==========================================
+ Hits          847      978     +131     
- Misses        100      119      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@doug-wade doug-wade merged commit d7a712a into master Dec 17, 2023
6 of 7 checks passed
@doug-wade doug-wade deleted the fix-134 branch December 17, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant