Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup-after-commit for #854 and #856 #858

Merged
merged 1 commit into from Feb 17, 2024
Merged

Conversation

stleary
Copy link
Owner

@stleary stleary commented Feb 14, 2024

Description
Converted tabs to spaces in cdl, and updated javadocs.
Reverted v8 config entry in pom.xml

Refactoring
N/A

Testing done
Passed maven and gradlew build tests

@stleary
Copy link
Owner Author

stleary commented Feb 14, 2024

What problem does this code solve?
Cleanup minor issues after #854 and #856 commits. No code changes.

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No

Was any code refactored in this commit?
No

Review status
APPROVED - by myself

Note
Reverting the change to pom.xml may result in a build warning:
[WARNING] bootstrap class path not set in conjunction with -source 8

Starting 3-day comment window

@stleary stleary merged commit 77c899d into master Feb 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant