Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability for custom delimiters #856

Merged
merged 1 commit into from Feb 13, 2024

Conversation

michael-ameri
Copy link
Contributor

No description provided.

@stleary
Copy link
Owner

stleary commented Feb 10, 2024

What problem does this code solve?
Users should be able to specify the delimiter when converting to/from CDL

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
New API methods were added that include a delimiter param

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, new unit tests were added

Was any code refactored in this commit?
Some of the unit tests were touched, but no functional changes were made to existing tests.
Tabs were used instead of spaces in CDL.java, this will be fixed in a follow-on commit.

Review status
APPROVED

Starting 3-day comment window

@stleary stleary merged commit 8550175 into stleary:master Feb 13, 2024
7 checks passed
stleary added a commit that referenced this pull request Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants