Am I still supposed to use the karma-coverage fork?

[lukescott]

I'm trying karma coverage 0.3.1. karma-runner/karma-coverage/pull/130 was merged, but I'm getting the following error:

ERROR [coverage]: [TypeError: Cannot read property 'split' of undefined]
TypeError: Cannot read property 'split' of undefined
    at HtmlReport.Report.mix.writeDetailPage (/Users/lukescott/Documents/Projects/webconnex/director-js/node_modules/istanbul/lib/report/html.js:395:30)
    at /Users/lukescott/Documents/Projects/webconnex/director-js/node_modules/istanbul/lib/report/html.js:472:26
    at SyncFileWriter.extend.writeFile (/Users/lukescott/Documents/Projects/webconnex/director-js/node_modules/istanbul/lib/util/file-writer.js:57:9)
    at FileWriter.extend.writeFile (/Users/lukescott/Documents/Projects/webconnex/director-js/node_modules/istanbul/lib/util/file-writer.js:147:23)
    at /Users/lukescott/Documents/Projects/webconnex/director-js/node_modules/istanbul/lib/report/html.js:471:24
    at Array.forEach (native)
    at HtmlReport.Report.mix.writeFiles (/Users/lukescott/Documents/Projects/webconnex/director-js/node_modules/istanbul/lib/report/html.js:465:23)
    at /Users/lukescott/Documents/Projects/webconnex/director-js/node_modules/istanbul/lib/report/html.js:467:22
    at Array.forEach (native)
    at HtmlReport.Report.mix.writeFiles (/Users/lukescott/Documents/Projects/webconnex/director-js/node_modules/istanbul/lib/report/html.js:465:23)

It works with the fork though.

[douglasduteil]

I don't know... I will be testing this tonight

[cgmartin]

+1 Also getting exact error/stacktrace using karma-coverage@0.3.1

[rossbayer]

+1 I can report the same, works fine with fork, does not work against karma-coverage@0.3.1

[kentcdodds]

Everything is working fine for me without using the fork. I'm using 0.3.1

[cgmartin]

Not seeing this error now using karma-coverage@0.4.2

[dignifiedquire]

No need for the fork anymore :) If there is the need change something to make it work, please open a PR/issue on karma/karma-coverage

[rovolution]

No need for the fork anymore :) If there is the need change something to make it work, please open a PR/issue on karma/karma-coverage

If this is the case, could you update the README to indicate this @douglasduteil?

Thanks!

[Sjors]

I can confirm I didn't need the douglasduteil/karma-coverage#next fork.

[martinmicunda]

@Sjors what version of karma-coverage are you using? I have still problem that my code is showing as ES5 and not ES6 (I have opened issue in karma-coverage plugin)

[onlywei]

I just tried to switch to karma-coverage@0.5.2 and my code started showing ES5 instead of ES6. Looks like we still need the fork?

[blittle]

Having the same problem with 0.5.3. I see ES5 code instead of ES6.

[AdamWillden]

Is this a problem with isparta or karma-coverage? +1 to fixing this either way.

[omichelsen]

+1