Skip to content
This repository has been archived by the owner. It is now read-only.

Am I still supposed to use the karma-coverage fork? #38

Open
lukescott opened this issue May 12, 2015 · 13 comments
Open

Am I still supposed to use the karma-coverage fork? #38

lukescott opened this issue May 12, 2015 · 13 comments
Labels

Comments

@lukescott
Copy link
Contributor

@lukescott lukescott commented May 12, 2015

I'm trying karma coverage 0.3.1. karma-runner/karma-coverage/pull/130 was merged, but I'm getting the following error:

ERROR [coverage]: [TypeError: Cannot read property 'split' of undefined]
TypeError: Cannot read property 'split' of undefined
    at HtmlReport.Report.mix.writeDetailPage (/Users/lukescott/Documents/Projects/webconnex/director-js/node_modules/istanbul/lib/report/html.js:395:30)
    at /Users/lukescott/Documents/Projects/webconnex/director-js/node_modules/istanbul/lib/report/html.js:472:26
    at SyncFileWriter.extend.writeFile (/Users/lukescott/Documents/Projects/webconnex/director-js/node_modules/istanbul/lib/util/file-writer.js:57:9)
    at FileWriter.extend.writeFile (/Users/lukescott/Documents/Projects/webconnex/director-js/node_modules/istanbul/lib/util/file-writer.js:147:23)
    at /Users/lukescott/Documents/Projects/webconnex/director-js/node_modules/istanbul/lib/report/html.js:471:24
    at Array.forEach (native)
    at HtmlReport.Report.mix.writeFiles (/Users/lukescott/Documents/Projects/webconnex/director-js/node_modules/istanbul/lib/report/html.js:465:23)
    at /Users/lukescott/Documents/Projects/webconnex/director-js/node_modules/istanbul/lib/report/html.js:467:22
    at Array.forEach (native)
    at HtmlReport.Report.mix.writeFiles (/Users/lukescott/Documents/Projects/webconnex/director-js/node_modules/istanbul/lib/report/html.js:465:23)

It works with the fork though.

@douglasduteil
Copy link
Owner

@douglasduteil douglasduteil commented May 15, 2015

I don't know... I will be testing this tonight

@cgmartin
Copy link

@cgmartin cgmartin commented May 21, 2015

+1 Also getting exact error/stacktrace using karma-coverage@0.3.1

@rossbayer
Copy link

@rossbayer rossbayer commented Jun 8, 2015

+1 I can report the same, works fine with fork, does not work against karma-coverage@0.3.1

@kentcdodds
Copy link

@kentcdodds kentcdodds commented Jun 12, 2015

Everything is working fine for me without using the fork. I'm using 0.3.1

@cgmartin
Copy link

@cgmartin cgmartin commented Jun 13, 2015

Not seeing this error now using karma-coverage@0.4.2

@dignifiedquire
Copy link

@dignifiedquire dignifiedquire commented Aug 6, 2015

No need for the fork anymore :) If there is the need change something to make it work, please open a PR/issue on karma/karma-coverage

@rovolution
Copy link

@rovolution rovolution commented Aug 13, 2015

No need for the fork anymore :) If there is the need change something to make it work, please open a PR/issue on karma/karma-coverage

If this is the case, could you update the README to indicate this @douglasduteil?

Thanks!

@Sjors
Copy link

@Sjors Sjors commented Sep 4, 2015

I can confirm I didn't need the douglasduteil/karma-coverage#next fork.

@martinmicunda
Copy link

@martinmicunda martinmicunda commented Sep 14, 2015

@Sjors what version of karma-coverage are you using? I have still problem that my code is showing as ES5 and not ES6 (I have opened issue in karma-coverage plugin)

@onlywei
Copy link

@onlywei onlywei commented Sep 15, 2015

I just tried to switch to karma-coverage@0.5.2 and my code started showing ES5 instead of ES6. Looks like we still need the fork?

@blittle
Copy link

@blittle blittle commented Dec 22, 2015

Having the same problem with 0.5.3. I see ES5 code instead of ES6.

@AdamWillden
Copy link

@AdamWillden AdamWillden commented Dec 29, 2015

Is this a problem with isparta or karma-coverage? +1 to fixing this either way.

@omichelsen
Copy link

@omichelsen omichelsen commented Feb 23, 2016

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.