Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double logging since v3.1.1 #280

Open
zoellner opened this issue Jun 29, 2023 · 1 comment
Open

Double logging since v3.1.1 #280

zoellner opened this issue Jun 29, 2023 · 1 comment

Comments

@zoellner
Copy link
Contributor

zoellner commented Jun 29, 2023 •
edited

This PR in #263 seems to have had a probably unintended side effect:
I am using serverless-http with express and the logger pino-http. Starting at serverless-http@3.1.1 I am seeing all request logs getting logged twice.
I added a super minimal demo project here to show the issue: https://github.com/zoellner/serverless-http-pino-bug

Originally posted by @zoellner in #263 (comment)
palfrey added a commit to palfrey/serverless-http that referenced this issue Sep 1, 2023
@palfrey
Resolves the multiple emit from dougmoscrop#280
508c976
This was referenced Sep 1, 2023
Merged
Closed
palfrey added a commit to palfrey/serverless-http that referenced this issue Sep 8, 2023
@palfrey
Resolves the multiple emit from dougmoscrop#280
4c9a15b
dougmoscrop pushed a commit that referenced this issue Sep 21, 2023
@palfrey
Resolves the multiple emit from #280 (#286)
d2f123b 
* Redid the integration tests using serverless-offline

* Split offline and AWS editions of the integration tests

* Run integration test in Github

* Integration needs "npm run"

* Re-enable node14.x tests

* Demo the pino case doing double logging

* Resolves the multiple emit from #280
@shftlvch
Copy link

same issue, thnx @zoellner for troubleshooting, downgraded to 3.1

BTW: can anyone point me out why pino logs request aborted instead of completed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shftlvch @zoellner