Redid the integration tests using serverless-offline #288
Conversation
test/integration/test.js
Outdated
| @@ -139,7 +158,8 @@ runtimes.forEach(runtime => { | |||
| .expect('Content-Type', /json/); | |||
| }); | |||
|
|
|||
| it('root', () => { | |||
| // FIXME: Broken currently https://github.com/dougmoscrop/serverless-http/issues/270 | |||
| it.skip('root', () => { | |||
package.json
Outdated
| @@ -18,7 +18,7 @@ | |||
| "pretest": "tsc --strict --skipLibCheck --noEmit test/typecheck.ts", | |||
| "test": "nyc mocha", | |||
| "posttest": "eslint lib test", | |||
| "test:integration": "mocha test/integration/test.js", | |||
| "test:integration": "mocha test/integration/test.js --exit", | |||
There was a problem hiding this comment.
Not sure what's hanging around given the process kills, but doesn't work without this.
|
Interesting, I'm a fan of using the actual AWS service in case there's drift between serverless-offline, but I also see the value in being able to use it - do you think we could support both? |
Added. I've also plugged the offline integration into the new Github actions work. |
|
@palfrey do you mind rebasing? |
palfrey
force-pushed
the
offline-integration-tests
branch
from
f6ec22a
to
5ed776b
Compare
|
This all got merged as part of #286 |
As part of looking at #280, I couldn't figure out how to get the integration tests running without actually deploying things to AWS. This PR redoes them with
serverless-offline.