Serrated Edges 3D Potential Flow Simulation #235
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es when using gmsh.
…er or Navier Stokes physics model. Added potential source parameters file. Added new cellwise_geometry_condition to ModelBase
…. Began fixing bug where LiftDragFunctional is initialized without considering ModelBase or alternative physics.
… has_manufactured_solution = false.
… updated if used with ModelBase
…d if used with ModelBase
…ntial_source_term
General cleaning of code.
jbrillon
reviewed
Aug 14, 2023
| @@ -371,6 +366,10 @@ bool DGBaseState<dim,nstate,real,MeshType>::potential_body_geometry( | |||
|
|
|||
|
|
|||
| // checking if position within TES geometry | |||
| // TES shape | |||
| auto TES = [&](real v) { | |||
There was a problem hiding this comment.
just wondering, what does [&](real v) do? I've never seen this before
There was a problem hiding this comment.
Passes the real variable v as a reference. (real v) is just a stand in for whatever variable is passed in the expression.
See the below article for reference, my understanding is lambdas are just a replacement for function pointers. In this case not really needed now that I look back on it... Could just be written inline.
… fix periodic parallel bug.
aidanchristoffersson
force-pushed
the
potential_source_term
branch
from
27669cd
to
0fd0453
Compare
Solution output and mesh input is currently setup for local machine.
…r naca0012 periodic case. The purpose of this spanwise refinement is to avoid the failure that occurs when periodic cells are assigned to different processors. Input meshes must be 1 cell spanwise, which is then refined using deal.ii after the processors are assigned. This ensures that each processor is responsible for the entire width of its segment.
aidanchristoffersson
force-pushed
the
potential_source_term
branch
from
a5e30fc
to
8db32a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rough draft for review.