Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support generate echo and gin server with protobuf #696

Merged
merged 17 commits into from
Feb 3, 2023
Merged

Conversation

sysulq
Copy link
Member

@sysulq sysulq commented Feb 1, 2023

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@sysulq sysulq temporarily deployed to tablestore-live February 1, 2023 08:42 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2023

Codecov Report

Merging #696 (9936589) into master (9357ae1) will decrease coverage by 0.35%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #696      +/-   ##
==========================================
- Coverage   53.19%   52.85%   -0.35%     
==========================================
  Files         190      192       +2     
  Lines       10329    10389      +60     
==========================================
- Hits         5495     5491       -4     
- Misses       4414     4482      +68     
+ Partials      420      416       -4     
Impacted Files Coverage Δ
proto/testproto/v1/hello.pb.go 38.81% <ø> (ø)
proto/testproto/v1/hello_echo.pb.go 0.00% <0.00%> (ø)
proto/testproto/v1/hello_gin.pb.go 0.00% <0.00%> (ø)
proto/testproto/v1/hello_grpc.pb.go 41.37% <ø> (ø)
pkg/client/redis/init.go 12.50% <0.00%> (-40.00%) ⬇️
pkg/client/resty/resty.go 77.94% <0.00%> (-10.68%) ⬇️
pkg/core/metric/gauge.go 76.00% <0.00%> (-8.00%) ⬇️
pkg/client/rocketmq/producer.go 51.16% <0.00%> (-1.22%) ⬇️
pkg/registry/etcdv3/registry.go 71.23% <0.00%> (-1.03%) ⬇️
pkg/client/rocketmq/pull_consumer.go 56.02% <0.00%> (-0.81%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sysulq sysulq temporarily deployed to tablestore-live February 1, 2023 08:52 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live February 1, 2023 09:00 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live February 1, 2023 09:28 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live February 1, 2023 09:40 — with GitHub Actions Inactive
@sysulq
Copy link
Member Author

sysulq commented Feb 1, 2023

goos: darwin
goarch: amd64
pkg: github.com/douyu/jupiter/test/benchmark
cpu: Intel(R) Core(TM) i5-10600K CPU @ 4.10GHz
BenchmarkHTTP/HTTP_with_reflect-12         	  102470	     11637 ns/op	    9739 B/op	      75 allocs/op
BenchmarkHTTP/HTTP_with_json-12            	  232111	      4875 ns/op	    7497 B/op	      34 allocs/op
BenchmarkHTTP/HTTP_with_grpc_gateway-12    	   85812	     13892 ns/op	   11322 B/op	     109 allocs/op
BenchmarkHTTP/HTTP_with_echo_gateway-12    	  225024	      5269 ns/op	    7954 B/op	      38 allocs/op
PASS
coverage: [no statements]
ok  	github.com/douyu/jupiter/test/benchmark	5.098s

@sysulq sysulq temporarily deployed to tablestore-live February 1, 2023 11:18 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live February 2, 2023 08:08 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live February 2, 2023 08:12 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live February 3, 2023 03:10 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live February 3, 2023 03:14 — with GitHub Actions Inactive
@sysulq
Copy link
Member Author

sysulq commented Feb 3, 2023

goos: darwin
goarch: amd64
pkg: github.com/douyu/jupiter/test/benchmark
cpu: Intel(R) Core(TM) i5-10600K CPU @ 4.10GHz
BenchmarkHTTP/HTTP_with_reflect-12         	  102470	     11637 ns/op	    9739 B/op	      75 allocs/op
BenchmarkHTTP/HTTP_with_json-12            	  232111	      4875 ns/op	    7497 B/op	      34 allocs/op
BenchmarkHTTP/HTTP_with_grpc_gateway-12    	   85812	     13892 ns/op	   11322 B/op	     109 allocs/op
BenchmarkHTTP/HTTP_with_echo_gateway-12    	  225024	      5269 ns/op	    7954 B/op	      38 allocs/op
PASS
coverage: [no statements]
ok  	github.com/douyu/jupiter/test/benchmark	5.098s

Add HTTP_with_gin_stdjson_gateway case

goos: darwin
goarch: amd64
pkg: github.com/douyu/jupiter/test/benchmark
cpu: Intel(R) Core(TM) i5-10600K CPU @ 4.10GHz
BenchmarkHTTP/HTTP_with_reflect-12         	  100839	     11942 ns/op	    9739 B/op	      75 allocs/op
BenchmarkHTTP/HTTP_with_echo_json-12       	  223934	      5666 ns/op	    7495 B/op	      34 allocs/op
BenchmarkHTTP/HTTP_with_grpc_gateway-12    	   81717	     14571 ns/op	   11321 B/op	     109 allocs/op
BenchmarkHTTP/HTTP_with_echo_stdjson_gateway-12         	  215925	      5575 ns/op	    7952 B/op	      38 allocs/op
BenchmarkHTTP/HTTP_with_echo_protojson_gateway-12       	  128109	      9414 ns/op	    9225 B/op	      68 allocs/op
BenchmarkHTTP/HTTP_with_gin_stdjson_gateway-12          	  178164	      7200 ns/op	    8280 B/op	      46 allocs/op
PASS
coverage: [no statements]
ok  	github.com/douyu/jupiter/test/benchmark	8.791s

@sysulq sysulq temporarily deployed to tablestore-live February 3, 2023 03:22 — with GitHub Actions Inactive
@sysulq sysulq temporarily deployed to tablestore-live February 3, 2023 03:32 — with GitHub Actions Inactive
@sysulq sysulq changed the title feat: support generate echo server with protobuf feat: support generate echo&gin server with protobuf Feb 3, 2023
@sysulq sysulq changed the title feat: support generate echo&gin server with protobuf feat: support generate echo and gin server with protobuf Feb 3, 2023
@sysulq sysulq temporarily deployed to tablestore-live February 3, 2023 04:39 — with GitHub Actions Inactive
@sysulq sysulq merged commit ac0c8e3 into master Feb 3, 2023
@sysulq sysulq deleted the feat/pb-echo branch February 17, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants